New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javascript unsigned signed typed arrays return same hash #114

Merged

addaleax merged 2 commits into puleos:master from ArtiomTr:Javascript-unsigned-signed-typed-arrays-return-same-hash

Feb 18, 2022

Contributor

ArtiomTr commented Feb 18, 2022 •

edited

Loading

This PR:

Fixes typo in _int8array, _int16array and _int32array hashing functions.
Adds tests to ensure that the hash function respects different types of javascript typed arrays.

Closes #113

ArtiomTr added 2 commits

February 18, 2022 15:04


          Created failing test

f48211f


          Fixed bug

addaleax approved these changes

View reviewed changes

addaleax merged commit 04db18b into puleos:master

Collaborator

addaleax commented Feb 18, 2022

Thank you! ✨ This is published in v3.0.0 now (due to the hash-change-is-breaking policy mentioned in the README file)

kachkaev mentioned this pull request

Changelog for v3 #116

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet