-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate config registers from the LLC implementation #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Thank you so much.
I will fix some minor things myself, merge and release.
thommythomaso
previously approved these changes
Nov 21, 2022
thommythomaso
previously approved these changes
Nov 21, 2022
thommythomaso
force-pushed
the
feature/generic-regs
branch
5 times, most recently
from
November 21, 2022 07:21
2f5b57e
to
99233c9
Compare
This was referenced Nov 21, 2022
thommythomaso
force-pushed
the
feature/generic-regs
branch
from
November 21, 2022 07:23
99233c9
to
6c823ff
Compare
thommythomaso
force-pushed
the
feature/generic-regs
branch
from
November 21, 2022 07:28
6c823ff
to
aa42cd6
Compare
thommythomaso
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate config registers allow use of custom or re-use of existing register files