Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Michaero/v5.0.0 draft #96

Merged
merged 50 commits into from
May 23, 2024
Merged

Michaero/v5.0.0 draft #96

merged 50 commits into from
May 23, 2024

Conversation

micprog
Copy link
Member

@micprog micprog commented Mar 5, 2024

No description provided.

@micprog micprog requested a review from bluewww March 5, 2024 15:48
Makefile Show resolved Hide resolved
Copy link
Collaborator

@bluewww bluewww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem to reasonable. Did we test this PR somewhere in PULPissimo?

@bluewww
Copy link
Collaborator

bluewww commented Mar 6, 2024

needs a changelog entry

@micprog
Copy link
Member Author

micprog commented Mar 14, 2024

Added the changelog entry, tested in PULPissimo (see this WIP branch)

@micprog micprog requested a review from bluewww March 14, 2024 10:49
Copy link
Collaborator

@bluewww bluewww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let me know once your ready we will remove the draft from the PR title and merge.

I think the synth FPGA failures need to be addressed anyway on the PULPissimo level so these should not block us.

@bluewww bluewww merged commit 22c1294 into master May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants