pulp_file: Repositories & Remotes #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himdel
force-pushed
the
pulp-file
branch
3 times, most recently
from
a6d3bae to
767c04e
Compare
himdel
force-pushed
the
pulp-file
branch
3 times, most recently
from
1878035 to
c8a9bcd
Compare
Merged
himdel
added a commit
that referenced
this pull request
Dec 30, 2024
* remove uses of Certified
* DeleteAnsible{Remote,Repository}Modal -> Delete{Remote,Repository}Modal
* unbeta login, status
* remove double css import
both CollectionDependenciesList & CollectionUsedbyDependenciesList are only used from src/containers/collection-detail/collection-dependencies.tsx which already imports it
* fixup imports
nothing should import from under src/*/**
* conditional hr - only between resrouces
himdel
force-pushed
the
pulp-file
branch
3 times, most recently
from
007ce95 to
fc8ec03
Compare
|
So, on the one hand, this approach definitely adds too much duplicate code. Even when sharing DeleteRemoteModal, DeleteRepositoryModal, RemoteForm and RepositoryForm, and built on top of ListPage, it's still net +1.5 kLOC. On the other, this exists now, works, and is not making a common base + plugin actions implementation later any harder. Testing:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #81 - first parts
Adds a
Pulp filemenu section, withRepositoriesandRemotes, much like in Ansible.shares
RemoteForm&RepositoryForm,DeleteRemoteModalandDeleteRepositoryModal,LazyRepositoriesandLazyDistributions, andListPage/DetailPage*(TODO(later): share more code still, or switch to a common implementation with per-plugin sections/actions)
trying to follow a
plugin='ansible'|'file'|'rpm'prop pattern, with aplugin2api(plugin).RepositoryAPI.list(...)etc.