Adding GCP support #1123
Closed
Adding GCP support #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschneier/django-storages#1193 Required PR: pulp/pulpcore#3367 [noissue]
ipanova
reviewed
Nov 22, 2022
|
|
||
| def redirect_to_object_storage(self, artifact, return_media_type): | ||
| """ | ||
| Redirect to the passed artifact's file stored in the Azure storage. |
There was a problem hiding this comment.
I think we have a pulpcore function for this now.
edit: Maybe it's not exactly compatible yet...
ipanova
approved these changes
Nov 22, 2022
|
it was just a draft |
|
why closing it if the code does not need any changes? |
|
without CI I don't know if it needs more changes, better to start a PR when we have a CI job for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jschneier/django-storages#1193
Required PR: pulp/pulpcore#3367
No Issue! Just a draft PR to have an idea on what is needed for GCP support