Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publishing a source package that belongs to two dists raises IntegrityError #1053

Closed
daviddavis opened this issue Mar 25, 2024 · 2 comments · Fixed by #1054
Closed

Publishing a source package that belongs to two dists raises IntegrityError #1053

daviddavis opened this issue Mar 25, 2024 · 2 comments · Fixed by #1054
Labels
.bugfix CHANGES/<issue_number>.bugfix

Comments

@daviddavis
Copy link
Contributor

Steps to reproduce:

  1. Create a source package
  2. Add it to two dists in a repo
  3. Publish the repo.

You'll get an IntegrityError. Basically the source package publish code needs something similar to this line:

pulp_deb/pulp_deb/app/tasks/publishing.py

Line 302 in 106f148

with suppress(IntegrityError):

daviddavis added a commit to daviddavis/pulp_deb that referenced this issue Mar 25, 2024
@daviddavis
Fix source package publish error
6490574 
Handle a source package publish IntegrityError when a source package
belongs to multiple dists.

fixes pulp#1053
@daviddavis daviddavis mentioned this issue Mar 25, 2024
Merged
daviddavis added a commit to daviddavis/pulp_deb that referenced this issue Mar 25, 2024
@daviddavis
Fix source package publish error
34545ba 
Handle a source package publish IntegrityError when a source package
belongs to multiple dists.

fixes pulp#1053
@quba42
Copy link
Collaborator

quba42 commented Mar 26, 2024

Sounds plausible given we had the exact same thing with binary packages.

@quba42 quba42 added .bugfix CHANGES/<issue_number>.bugfix and removed Triage-Needed labels Mar 26, 2024
@hstct
Copy link
Contributor

hstct commented Mar 26, 2024

Yea seems like one the things we missed when reviewing the source package PR

daviddavis added a commit to daviddavis/pulp_deb that referenced this issue Apr 4, 2024
@daviddavis
Fix source package publish error
8af1f9b 
Handle a source package publish IntegrityError when a source package
belongs to multiple dists.

fixes pulp#1053
daviddavis added a commit to daviddavis/pulp_deb that referenced this issue Apr 4, 2024
@daviddavis
Fix source package publish error
7305b0d 
Handle a source package publish IntegrityError when a source package
belongs to multiple dists.

fixes pulp#1053
daviddavis added a commit to daviddavis/pulp_deb that referenced this issue Apr 9, 2024
@daviddavis
Fix source package publish error
0ee3fc3 
Handle a source package publish IntegrityError when a source package
belongs to multiple dists.

fixes pulp#1053
@patchback patchback bot mentioned this issue Apr 10, 2024
Merged
hstct added a commit that referenced this issue Apr 11, 2024
@hstct
Fix source package publish error
283f8de 
Handle a source package publish IntegrityError when a source package
belongs to multiple dists.

fixes #1053

(cherry picked from commit 9e2a196)
hstct pushed a commit that referenced this issue Apr 11, 2024
@daviddavis @hstct
Fix source package publish error
3bb32a7 
Handle a source package publish IntegrityError when a source package
belongs to multiple dists.

fixes #1053

(cherry picked from commit 0ee3fc3)
hstct pushed a commit that referenced this issue Apr 24, 2024
@daviddavis @hstct
Fix source package publish error
9948657 
Handle a source package publish IntegrityError when a source package
belongs to multiple dists.

fixes #1053

(cherry picked from commit 0ee3fc3)
adrianabedon pushed a commit to adrianabedon/pulp_deb that referenced this issue Apr 24, 2024
@daviddavis
Fix source package publish error
a965c63 
Handle a source package publish IntegrityError when a source package
belongs to multiple dists.

fixes pulp#1053
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
.bugfix CHANGES/<issue_number>.bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix source package publish error daviddavis/pulp_deb
3 participants
@daviddavis @quba42 @hstct