Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support duplicate content for source debs #1077

Closed
garretwyman opened this issue May 9, 2024 · 1 comment · Fixed by #1078
Closed

Support duplicate content for source debs #1077

garretwyman opened this issue May 9, 2024 · 1 comment · Fixed by #1078
Labels
.feature CHANGES/<issue_number>.feature .removal CHANGES/<issue_number>.removal

Comments

@garretwyman
Copy link
Contributor

Pulpcore implemented a feature in 3.22.0 (pulp/pulpcore#3083) making pulp return href of existing content instead of throwing an exception. Currently in pulp_deb that log is used for debs, but not for source debs.

The request is to handle debs and source debs the same by removing the check that There is already a DSC file with version.
garretwyman added a commit to garretwyman/pulp_deb that referenced this issue May 9, 2024
@garretwyman
Removing the checking of existing source debs to implement feature in…
f7136ac 
… pulpcore. Fixes pulp#1077
garretwyman added a commit to garretwyman/pulp_deb that referenced this issue May 10, 2024
@garretwyman
Removing the checking of existing source debs to implement feature in…
f70e701 
… pulpcore. Fixes pulp#1077

Adding retrieve function
garretwyman added a commit to garretwyman/pulp_deb that referenced this issue May 10, 2024
@garretwyman
Removing the checking of existing source debs to implement feature in…
a88d350 
… pulpcore. Fixes pulp#1077

Adding retrieve function

changing comment
garretwyman added a commit to garretwyman/pulp_deb that referenced this issue May 10, 2024
@garretwyman
Remove the checking of existing source debs and instead return the ex…
11218b6 
…isting source package. Fixes pulp#1077
@garretwyman garretwyman mentioned this issue May 10, 2024
Merged
garretwyman added a commit to garretwyman/pulp_deb that referenced this issue May 10, 2024
@garretwyman
Remove the checking of existing source debs and instead return the ex…
c64b8c6 
…isting source package. Fixes pulp#1077

Fixing changelog
garretwyman added a commit to garretwyman/pulp_deb that referenced this issue May 10, 2024
@garretwyman
Remove the checking of existing source debs and instead return the ex…
99bb6cc 
…isting source package. Fixes pulp#1077

Fixing changelog

adding new line
@quba42 quba42 added .feature CHANGES/<issue_number>.feature .removal CHANGES/<issue_number>.removal and removed Triage-Needed labels May 13, 2024
@quba42
Copy link
Collaborator

quba42 commented May 13, 2024

We generally want the retrieve behavior for all API endpoints, so I have removed the Triage-Needed label.

Thanks for contributing a PR to fix this.

garretwyman added a commit to garretwyman/pulp_deb that referenced this issue May 13, 2024
@garretwyman
Remove the checking of existing source debs and instead return the ex…
458256a 
…isting source package. Fixes pulp#1077

Fixing changelog

adding new line

Adding changelog removal file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
.feature CHANGES/<issue_number>.feature .removal CHANGES/<issue_number>.removal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the checking of existing source debs garretwyman/pulp_deb
2 participants
@quba42 @garretwyman