Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert most CharField instances to TextField #532

Closed
quba42 opened this issue Jun 1, 2022 · 0 comments · Fixed by #534
Closed

Convert most CharField instances to TextField #532

quba42 opened this issue Jun 1, 2022 · 0 comments · Fixed by #534
Labels
.misc CHANGES/<issue_number>.misc Triage-Needed

Comments

@quba42
Copy link
Collaborator

quba42 commented Jun 1, 2022

There now seems to be a consensus for both pulpcore and pulp_rpm, that TextField is always better than CharField for Pulp.
I gather this is because of how PostgreSQL implements these two fields on the DB side.

For consistency pulp_deb should also follow suit.

See: pulp/pulp_rpm#2515 as a reference.
@quba42 quba42 added .misc CHANGES/<issue_number>.misc Triage-Needed labels Jun 1, 2022
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jun 1, 2022
@hstct
Convert CharField to TextField
f63b777 
closes pulp#532
@hstct hstct mentioned this issue Jun 1, 2022
Merged
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jun 1, 2022
@hstct
Convert CharField to TextField
ac4391d 
closes pulp#532
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jun 2, 2022
@hstct
Convert CharField to TextField
4ec0932 
closes pulp#532
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jun 2, 2022
@hstct
Convert CharField to TextField
0f74c55 
closes pulp#532
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jun 13, 2022
@hstct
Convert CharField to TextField
3d56df8 
closes pulp#532
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jun 13, 2022
@hstct
Convert CharField to TextField
ee1f870 
closes pulp#532
quba42 pushed a commit that referenced this issue Jun 13, 2022
@hstct @quba42
Convert CharField to TextField
1954f2b 
closes #532
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
.misc CHANGES/<issue_number>.misc Triage-Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert CharField to TextField ATIX-AG/pulp_deb
1 participant
@quba42