Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not validate_duplicate_content for APT repositories #632

Closed
quba42 opened this issue Aug 31, 2022 · 0 comments · Fixed by #633
Closed

Do not validate_duplicate_content for APT repositories #632

quba42 opened this issue Aug 31, 2022 · 0 comments · Fixed by #633
Labels
.bugfix CHANGES/<issue_number>.bugfix

Comments

@quba42
Copy link
Collaborator

quba42 commented Aug 31, 2022

Using validate_duplicate_content prevents successful synchronization when multiple package indices contain references to the same package. However, this is an entirely legitimate situation for separate distributions/releases within a single APT repo. Further more, the so created duplicate package content, does not cause any adverse effects, since it is actually identical and only one of each duplicate will be saved.

Note, that this bug was masked until the optimize feature was added, because we were using Repository instead of AptRepository during sync, inadvertently skipping the problematic check.

@quba42 quba42 added the .bugfix CHANGES/<issue_number>.bugfix label Aug 31, 2022
quba42 added a commit to ATIX-AG/pulp_deb that referenced this issue Aug 31, 2022
closes pulp#632

Using validate_duplicate_content prevents successfull synchronization
when multiple package indices contain references to the same package.
However, this is an entirely legitimate situation for separate
distributions/releases within a single APT repo. Further more, the so
created duplicate package content, does not cause any adverse effects,
since it is actually identical and only one of each duplicate will be
saved.
quba42 added a commit to ATIX-AG/pulp_deb that referenced this issue Aug 31, 2022
closes pulp#632

Using validate_duplicate_content prevents successfull synchronization
when multiple package indices contain references to the same package.
However, this is an entirely legitimate situation for separate
distributions/releases within a single APT repo. Further more, the so
created duplicate package content, does not cause any adverse effects,
since it is actually identical and only one of each duplicate will be
saved.

Note that this issue was masked prior to the introduction of the
optimize sync feature, since we were inadvertently using the Repository
class from pulpcore instead of the AptRepository class from pulp_deb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.bugfix CHANGES/<issue_number>.bugfix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant