Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for the new related content filters #780

Closed
quba42 opened this issue Jun 1, 2023 · 2 comments · Fixed by #781
Closed

Add a test for the new related content filters #780

quba42 opened this issue Jun 1, 2023 · 2 comments · Fixed by #781
Labels
.misc CHANGES/<issue_number>.misc Tests

Comments

@quba42
Copy link
Collaborator

quba42 commented Jun 1, 2023

#646 was added with #647, but still needs a "happy path" test.

It should be possible to extend an existing sync test by just applying the filter to the sync result, and checking that it finds the expected things.
@quba42 quba42 added .misc CHANGES/<issue_number>.misc Tests labels Jun 1, 2023
@quba42
Copy link
Collaborator Author

quba42 commented Jun 1, 2023

@sdherr

@quba42 quba42 mentioned this issue Jun 1, 2023
Merged
sdherr added a commit to sdherr/pulp_deb that referenced this issue Jun 2, 2023
@sdherr
Add tests for content filters, and make filters return empty list if …
46e89b5 
…Content not in RepoVersion instead of raising ValidationError.

closes pulp#780
@sdherr sdherr mentioned this issue Jun 2, 2023
Merged
sdherr added a commit to sdherr/pulp_deb that referenced this issue Jun 2, 2023
@sdherr
Add tests for content filters, and make filters return empty list if …
082e456 
…Content not in RepoVersion instead of raising ValidationError.

closes pulp#780
sdherr added a commit to sdherr/pulp_deb that referenced this issue Jun 2, 2023
@sdherr
Add tests for content filters, and make filters return empty list if …
2cc455b 
…Content not in RepoVersion instead of raising ValidationError.

closes pulp#780
@sdherr
Copy link
Contributor

sdherr commented Jun 2, 2023

@quba42 Done. :)

sdherr added a commit to sdherr/pulp_deb that referenced this issue Jun 5, 2023
@sdherr
Add tests for content filters, and make filters return empty list if …
3302e30 
…Content not in RepoVersion instead of raising ValidationError.

closes pulp#780
adamsanaglo pushed a commit to adamsanaglo/pulp_deb that referenced this issue Jul 20, 2023
@sdherr @adamsanaglo
Add tests for content filters, and make filters return empty list if …
559a51a 
…Content not in RepoVersion instead of raising ValidationError.

closes pulp#780
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
.misc CHANGES/<issue_number>.misc Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests for related content filters sdherr/pulp_deb
2 participants
@sdherr @quba42