Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structured upload does not work multiple times in a row #807

Closed
quba42 opened this issue Jun 19, 2023 · 0 comments · Fixed by #805
Closed

Structured upload does not work multiple times in a row #807

quba42 opened this issue Jun 19, 2023 · 0 comments · Fixed by #805
Labels
.bugfix CHANGES/<issue_number>.bugfix

Comments

@quba42
Copy link
Collaborator

quba42 commented Jun 19, 2023

Version
Affects 2.21.0

Describe the bug
When uploading a package starting with 2.21.0 and supplying at least the optional repository parameter here: https://docs.pulpproject.org/pulp_deb/restapi.html#tag/Content:-Packages/operation/content_deb_packages_create

pulp_deb should create not only a package, but also structured content and add it to the repo provided.
This seems to work with the first package uploaded to a repo, but strangely not with any that come after that. Instead no new repo version is created at all.

To Reproduce
See above

Expected behavior
Structured upload should always work.

Additional information

While we are at it, we could also improve the following:

  • Structure content is never added to the creating tasks created_resources right now.
  • There is zero logging to indicate a structured (rather than a regular) upload has happened.
@quba42 quba42 added Triage-Needed .bugfix CHANGES/<issue_number>.bugfix and removed Triage-Needed labels Jun 19, 2023
@quba42 quba42 linked a pull request Jun 19, 2023 that will close this issue
Structured upload fixes #805
Merged
quba42 added a commit to ATIX-AG/pulp_deb that referenced this issue Jun 19, 2023
@quba42
Rework structured upload
5520ab0 
closes pulp#807

List of chagnes:

- Added a info level log message about the structured upload.
- Ensured any extra content created is added to the created_resources
  list of the relevant task.
- Stopped using the blanke suppress of IntegrityError, which appears to
  have fixed repeated uploads to a repo not doing what they are supposed
  to.
quba42 added a commit to ATIX-AG/pulp_deb that referenced this issue Jun 19, 2023
@quba42
fixup! Rework structured upload
b4cc90d 
closes pulp#807
quba42 added a commit to ATIX-AG/pulp_deb that referenced this issue Jun 19, 2023
@quba42
fixup! Rework structured upload
4662949 
closes pulp#807
quba42 added a commit to ATIX-AG/pulp_deb that referenced this issue Jun 19, 2023
@quba42
Rework structured upload
0283e43 
closes pulp#807

List of chagnes:

- Added a info level log message about the structured upload.
- Ensured any extra content created is added to the created_resources
  list of the relevant task.
- Stopped using the blanket suppression of IntegrityError, which appears
  to have fixed repeated uploads to a repo not working as designed.
quba42 added a commit to ATIX-AG/pulp_deb that referenced this issue Jun 20, 2023
@quba42
Rework structured upload
d04da37 
closes pulp#807

List of chagnes:

- Added a info level log message about the structured upload.
- Ensured any extra content created is added to the created_resources
  list of the relevant task.
- Stopped using the blanket suppression of IntegrityError, which appears
  to have fixed repeated uploads to a repo not working as designed.
quba42 added a commit that referenced this issue Jun 20, 2023
@quba42
Rework structured upload
e755f87 
closes #807

List of chagnes:

- Added a info level log message about the structured upload.
- Ensured any extra content created is added to the created_resources
  list of the relevant task.
- Stopped using the blanket suppression of IntegrityError, which appears
  to have fixed repeated uploads to a repo not working as designed.

(cherry picked from commit d04da37)
@quba42 quba42 mentioned this issue Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
.bugfix CHANGES/<issue_number>.bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Structured upload fixes ATIX-AG/pulp_deb
1 participant
@quba42