Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It is not possible to modify the API root for the advanced copy test case #879

Closed
quba42 opened this issue Aug 30, 2023 · 0 comments · Fixed by #880
Closed

It is not possible to modify the API root for the advanced copy test case #879

quba42 opened this issue Aug 30, 2023 · 0 comments · Fixed by #880
Labels
.misc CHANGES/<issue_number>.misc prio-list

Comments

@quba42
Copy link
Collaborator

quba42 commented Aug 30, 2023

We have discovered this via the s3 test when we tried to add test coverage here: #878

After a long debugging session during pulp open floor, it was discovered that we had hard coded the API root for this endpoint, and the s3 test tries to modify the API root.

The solution is to set the API root for this endpoint as pulp_rpm already does: https://github.com/pulp/pulp_rpm/blob/main/pulp_rpm/app/urls.py
@quba42 quba42 added Triage-Needed .misc CHANGES/<issue_number>.misc prio-list and removed Triage-Needed labels Aug 30, 2023
quba42 added a commit to ATIX-AG/pulp_deb that referenced this issue Aug 30, 2023
@quba42
Fix API root for the deb/copy/ endpoint for s3
ceaa12e 
closes pulp#879
@quba42 quba42 mentioned this issue Aug 30, 2023
Merged
quba42 added a commit to ATIX-AG/pulp_deb that referenced this issue Aug 30, 2023
@quba42
Fix API root for the deb/copy/ endpoint for s3
fb624a9 
closes pulp#879
quba42 added a commit to ATIX-AG/pulp_deb that referenced this issue Aug 30, 2023
@quba42
Fix API root for the deb/copy/ endpoint for s3
6caf509 
closes pulp#879
This was referenced Aug 30, 2023
Merged
Merged
daviddavis pushed a commit to daviddavis/pulp_deb that referenced this issue Nov 20, 2023
@quba42 @daviddavis
Fix API root for the deb/copy/ endpoint for s3
939fffe 
closes pulp#879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
.misc CHANGES/<issue_number>.misc prio-list
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix API root for the deb/copy/ endpoint for s3 ATIX-AG/pulp_deb
1 participant
@quba42