Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide documentation for the pulp-cli plugin #595

Closed
wants to merge 1 commit into from

Conversation

mikalstill
Copy link

It would be nice to not have to make raw HTTP calls to manage repositories. This PR at the moment is just a minimal implementation of creating a repository, but I wanted to ask how you'd feel about a CLI plugin.

@mdellweg
Copy link
Member

mdellweg commented Jul 26, 2022

https://github.com/pulp/pulp-cli-deb

Please don't duplicate the work. ;)
It's documented there: https://docs.pulpproject.org/pulp_cli/#cli-plugins

@mikalstill
Copy link
Author

I didn't even realise this existed. May I ask why the pulp-deb docs use http instead of this CLI?

@quba42
Copy link
Collaborator

quba42 commented Jul 28, 2022

I didn't even realise this existed. May I ask why the pulp-deb docs use http instead of this CLI?

Because pulp-cli-deb did not exist at the time the docs were written (and also pulp-cli-deb is not as fully feature full as the CLI for some of the other plugins). Adding docs about pulp-cli-deb is definitely wanted, but nobody has time to work on them. 😞

@quba42
Copy link
Collaborator

quba42 commented Jul 28, 2022

I guess it might be worth making it a priority to add at least some minimal docs to inform users that pulp-cli-deb exists.

@mikalstill
Copy link
Author

Thanks for the reply. I'm happy enough to pivot this PR into being tweaks to the docs pointing at the exist CLI plugin. Do I need to create an issue for that before updating this PR?

@quba42
Copy link
Collaborator

quba42 commented Aug 1, 2022

Do I need to create an issue for that before updating this PR?

I went ahead and created one you can use: #598

Fixes pulp#598, but noting that the CLI plugin is currently incomplete.
@mikalstill
Copy link
Author

Questions and comments from a first pass at this:

  • is it just me, or is it a bit clumbersome that the CLI plugin returns JSON blocks that a user then needs to parse?
  • there are obvious gaps for sync / upload in the CLI plugin.

@mikalstill mikalstill changed the title WIP: start implementing a pulp-cli plugin Provide documentation for the pulp-cli plugin Aug 2, 2022
@quba42
Copy link
Collaborator

quba42 commented Aug 2, 2022

  • is it just me, or is it a bit clumbersome that the CLI plugin returns JSON blocks that a user then needs to parse?

AFAIK this is exactly the same as for Pulp CLI for any other Pulp plugin like pulp_rpm, though I believe it is also configurable:

# pulp config create --help
  --format [json|yaml|none]       Format of the response

Never tried any of the other formats, so I have no idea if they are more or less convenient.

  • there are obvious gaps for sync / upload in the CLI plugin.

I am not aware of any gaps for sync, but there are certainly known feature gaps including for upload: https://github.com/pulp/pulp-cli-deb/issues

@quba42 quba42 added the .doc CHANGES/<issue_number>.doc label Oct 19, 2022
@stale
Copy link

stale bot commented Jan 17, 2023

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

@stale stale bot added the stale label Jan 17, 2023
@stale
Copy link

stale bot commented Jan 17, 2023

This issue is no longer marked for closure.

@stale stale bot removed the stale label Jan 17, 2023
@stale
Copy link

stale bot commented Apr 18, 2023

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

@stale stale bot added the stale label Apr 18, 2023
@quba42 quba42 removed the stale label Apr 18, 2023

.. code-block:: bash

sudo pip3 install pulp_cli_deb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not use sudo pip. Talk about a virtual env if you like...

@stale
Copy link

stale bot commented Jul 17, 2023

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

@stale stale bot added the stale label Jul 17, 2023
@quba42 quba42 removed the stale label Jul 17, 2023
@mikalstill mikalstill closed this Jul 20, 2023
@quba42
Copy link
Collaborator

quba42 commented Aug 30, 2023

Note that we will now be adding Pulp CLI workflows for the pulp_deb 3.0 release: #876

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.doc CHANGES/<issue_number>.doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants