This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Do not create symlinks for collectstatic #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simaishi
force-pushed
the
collectstatic_no_link
branch
from
b577031 to
d2edb91
Compare
|
CI issues are unrelated and due to external changes. Merging. |
Backport to 3.21: 💚 backport PR created✅ Backport PR branch: Backported as #1490 🤖 @patchback |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During upgrade, collectstatic call might leave stale symlinks even with
--cleanoption and that causes pulp not to start. After consulting with pulp team, we have agreed it is safer to copy files rather than symlink.Fixes: #1488