[PR #5936/58425d79 backport][3.66] Fix Any serializer type regression breaking Ruby bindings #5947
+22
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
See pulp/pulp_rpm#3639 (cherry picked from commit 58425d7)
mdellweg
approved these changes
Oct 30, 2024
mdellweg
deleted the
patchback/backports/3.66/58425d791296752be427a43cda9df0d2403bc7bc/pr-5936
branch
pedro-psb
added a commit
to pedro-psb/pulpcore
that referenced
this pull request
Nov 27, 2024
Our RemoteArtifact streaming uses chunked transfer, so once it has started a response, we can't fix anything anymore in case an error. Because of that, the retry logic (any of the timeout, digest, etc) on the http downloader is just delaying a response that can't be possible right anymore. Closes pulp#5947
pedro-psb
added a commit
to pedro-psb/pulpcore
that referenced
this pull request
Nov 27, 2024
Our RemoteArtifact streaming uses chunked transfer, so once it has started a response, we can't fix anything anymore in case an error. Because of that, the retry logic (any of the timeout, digest, etc) on the http downloader is just delaying a response that can't be possible right anymore. Closes pulp#5947
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #5936 as merged into main (58425d7).
See pulp/pulp_rpm#3639