Better error reporting #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daeraxa
reviewed
Dec 10, 2023
Co-authored-by: Daeraxa <58074586+Daeraxa@users.noreply.github.com>
Co-authored-by: Daeraxa <58074586+Daeraxa@users.noreply.github.com>
…/package-frontend into improved-error-pages
Daeraxa
reviewed
Dec 11, 2023
Daeraxa
approved these changes
Dec 11, 2023
|
Thanks for the review @Daeraxa! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds much better error reporting to the package frontend.
Previously any and all errors are swallowed on the frontend, showing generic, ugly, unstyled error pages. Even worse, not logging the nature of the error.
This PR fixes all of these issues, instead by creating an error page that maintains the style of the site, while also showing the error to the user, in such a way that they may be able to find the issue at hand, or if need be, report a detailed error message to us in the event they see this screen.
Additionally, this PR logs the errors as well.
This PR focuses on adding this behavior to the package list pages, as well as the individual package pages. As these are we are seeing the vast majority of our errors occur.
This PR is also the first step needed in determining what is going wrong with our recurrent rogue instances of the PPR frontend, when an instance goes rogue and causes the chance for failure for users. Since as of now, we are completely in the dark in what goes wrong, having proper logging, and even better being much more transparent about what's gone wrong, will hopefully be the first and final step needed to determine why this happens, and how we can fix it.