forked from atom/superstring
-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendorize libiconv
on macOS
#11
Closed
savetheclocktower
wants to merge
12
commits into
pulsar-edit:master
from
savetheclocktower:install-name-fix
Closed
Vendorize libiconv
on macOS
#11
savetheclocktower
wants to merge
12
commits into
pulsar-edit:master
from
savetheclocktower:install-name-fix
Commits on Jul 2, 2024
-
Add a vendored version of
libiconv
for macOS……to match the version that `superstring` expects. This is copied directly from what Homebrew installs into `$(brew --prefix)/opt/libiconv`, except that the install name has been changed on `libiconv.2.dylib` to `libiconv.2.dylib`. (When it's installed from Homebrew, its macOS library “install name” matches its original path, so that's where macOS looks for it. As part of the build, we rename the library with `install_name_tool` so that it can be resolved relative to the location of `superstring.node`. This can probably be simplified, but first let's see if it'll work.
Configuration menu - View commit details
-
Copy full SHA for 8873e70 - Browse repository at this point
Copy the full SHA 8873e70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16013d7 - Browse repository at this point
Copy the full SHA 16013d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ecf7a3 - Browse repository at this point
Copy the full SHA 3ecf7a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1011395 - Browse repository at this point
Copy the full SHA 1011395View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3e9358 - Browse repository at this point
Copy the full SHA a3e9358View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a43de6 - Browse repository at this point
Copy the full SHA 2a43de6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0422671 - Browse repository at this point
Copy the full SHA 0422671View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2378f1e - Browse repository at this point
Copy the full SHA 2378f1eView commit details -
…because we need a version built for the current machine's architecture. (If our current approach doesn't work, we could vendorize two different copies — one for each architecture.)
Configuration menu - View commit details
-
Copy full SHA for 50aff7b - Browse repository at this point
Copy the full SHA 50aff7bView commit details -
Add script that dynamically vendorizes
libiconv
……by grabbing it from Homebrew or from a path specified by the user in an environment variable.
Configuration menu - View commit details
-
Copy full SHA for 9466a42 - Browse repository at this point
Copy the full SHA 9466a42View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f2232c - Browse repository at this point
Copy the full SHA 6f2232cView commit details
Commits on Jul 3, 2024
-
Future-proof the build process…
…by adding an alternate strategy that we can adopt if we ever need to. Also copy over `libiconv`’s README and license file.
Configuration menu - View commit details
-
Copy full SHA for a4c374b - Browse repository at this point
Copy the full SHA a4c374bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.