Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: アカウントの複数一括取得の実装 #588

Merged
merged 6 commits into from
Jul 25, 2024

Conversation

laminne
Copy link
Member

@laminne laminne commented Jul 24, 2024

What does this PR do?

close #587

  • アカウントを複数取得するfetchAccountsの実装
    • 内部用のメソッドなのでAccountModuleFacadeから呼び出せるように

Additional information

@laminne laminne added the T: feature New feature label Jul 24, 2024
@laminne laminne requested review from MikuroXina and m1sk9 July 24, 2024 10:01
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 87.60331% with 15 lines in your changes missing coverage. Please review.

Project coverage is 53.52%. Comparing base (6375c27) to head (bacc222).

Files Patch % Lines
pkg/accounts/adaptor/repository/prisma.ts 8.33% 11 Missing ⚠️
pkg/intermodule/account.ts 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
+ Coverage   52.93%   53.52%   +0.59%     
==========================================
  Files         114      115       +1     
  Lines        8711     8824     +113     
  Branches      780      788       +8     
==========================================
+ Hits         4611     4723     +112     
- Misses       4100     4101       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laminne laminne requested a review from MikuroXina July 24, 2024 10:08
pkg/accounts/model/repository.ts Outdated Show resolved Hide resolved
@laminne laminne merged commit e436121 into main Jul 25, 2024
3 checks passed
@laminne laminne deleted the feat/587-fetch-accounts branch July 25, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: アカウントの複数一括取得を実装する
3 participants