Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Note/DriveモジュールのDIでEtherを使うようにした #791

Merged
merged 6 commits into from
Oct 24, 2024

Conversation

laminne
Copy link
Member

@laminne laminne commented Oct 23, 2024

close #788

What does this PR do?

  • Noteモジュール、DriveモジュールのDIでEtherを使うようにしました
  • Intermoduleで公開されるEtherがモードに関係なくプロダクション用のものを使っていたのでそれをモードによって切り替えられるようにしました

Additional information

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 43.77880% with 122 lines in your changes missing coverage. Please review.

Project coverage is 49.41%. Comparing base (a9bdde7) to head (679b240).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/notes/mod.ts 0.00% 62 Missing ⚠️
pkg/notes/adaptor/repository/prisma.ts 0.00% 18 Missing ⚠️
pkg/notes/adaptor/repository/dummy.ts 25.00% 15 Missing ⚠️
pkg/drive/mod.ts 0.00% 8 Missing ⚠️
pkg/notes/service/create.ts 66.66% 6 Missing ⚠️
pkg/notes/service/renote.ts 66.66% 6 Missing ⚠️
pkg/drive/adaptor/repository/prisma.ts 0.00% 3 Missing ⚠️
pkg/drive/adaptor/repository/dummy.ts 66.66% 1 Missing ⚠️
pkg/notes/service/createBookmark.ts 91.66% 1 Missing ⚠️
pkg/notes/service/createReaction.ts 91.66% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #791      +/-   ##
==========================================
+ Coverage   49.30%   49.41%   +0.11%     
==========================================
  Files         148      149       +1     
  Lines       13403    13540     +137     
  Branches     1052     1051       -1     
==========================================
+ Hits         6608     6691      +83     
- Misses       6795     6849      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/intermodule/account.ts Outdated Show resolved Hide resolved
pkg/intermodule/account.ts Outdated Show resolved Hide resolved
@laminne laminne merged commit eca4510 into main Oct 24, 2024
3 checks passed
@laminne laminne deleted the refactor/788-note-drive-module-di branch October 24, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: notes/driveモジュールのDIでEtherを使うようにする
2 participants