Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: アカウントのヘッダー/アバター画像の設定、設定解除ができるように #823

Merged
merged 12 commits into from
Nov 13, 2024

Conversation

laminne
Copy link
Member

@laminne laminne commented Nov 12, 2024

close #809

What does this PR do?

  • ヘッダーとアバター画像の設定、設定解除ができるように
  • アカウント取得時にヘッダー・アバター画像を(あれば)返すように
  • マイグレーションの追加(AccountHeader/AccountAvatar モデル)
  • MediaModuleFacadeの定義と実装
  • Service実装とDIシンボルの定義
  • APIの実装
  • Accountモジュール内の/repository/dummyのファイルを分割

Additional information

@laminne laminne added T: feature New feature P: high T: improvement Improvement of functions, etc. labels Nov 12, 2024
@laminne laminne self-assigned this Nov 12, 2024
@laminne laminne enabled auto-merge (squash) November 12, 2024 15:12
pkg/accounts/adaptor/controller/account.ts Outdated Show resolved Hide resolved
pkg/accounts/adaptor/controller/account.ts Outdated Show resolved Hide resolved
pkg/accounts/model/repository.ts Show resolved Hide resolved
pkg/drive/service/fetch.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 45.12195% with 765 lines in your changes missing coverage. Please review.

Project coverage is 48.98%. Comparing base (aa8a99a) to head (e315857).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/accounts/router.ts 0.00% 254 Missing ⚠️
pkg/accounts/mod.ts 0.00% 124 Missing ⚠️
pkg/accounts/adaptor/controller/account.ts 0.00% 122 Missing ⚠️
pkg/accounts/adaptor/repository/prisma/avatar.ts 0.00% 70 Missing ⚠️
pkg/accounts/adaptor/repository/prisma/header.ts 0.00% 70 Missing ⚠️
...counts/adaptor/repository/dummy/inactiveAccount.ts 0.00% 33 Missing ⚠️
pkg/accounts/adaptor/repository/dummy/follow.ts 61.76% 26 Missing ⚠️
pkg/accounts/adaptor/repository/dummy/avatar.ts 72.88% 16 Missing ⚠️
pkg/accounts/adaptor/repository/dummy/header.ts 72.88% 16 Missing ⚠️
pkg/accounts/service/avatar.ts 91.42% 9 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #823      +/-   ##
==========================================
- Coverage   49.40%   48.98%   -0.42%     
==========================================
  Files         149      161      +12     
  Lines       13771    14922    +1151     
  Branches     1077     1167      +90     
==========================================
+ Hits         6803     7310     +507     
- Misses       6968     7612     +644     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laminne laminne merged commit d770ea1 into main Nov 13, 2024
3 of 5 checks passed
@laminne laminne deleted the feat/809-account-images branch November 13, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P: high T: feature New feature T: improvement Improvement of functions, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: アカウントヘッダー/アイコン画像を設定できるようにする
2 participants