Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl account activation #851

Merged
merged 2 commits into from
Nov 28, 2024
Merged

feat: impl account activation #851

merged 2 commits into from
Nov 28, 2024

Conversation

laminne
Copy link
Member

@laminne laminne commented Nov 27, 2024

close #850

What does this PR do?

  • アカウントの有効化を実装
  • 適切にメールアドレス検証トークンを削除できるように
  • いくつかの部分で Promise.resolveを使わないように

Additional information

@laminne laminne self-assigned this Nov 27, 2024
@laminne laminne enabled auto-merge (squash) November 27, 2024 14:38
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 49.76%. Comparing base (45a003e) to head (ac0a77f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/accounts/adaptor/repository/prisma/prisma.ts 8.33% 11 Missing ⚠️
pkg/accounts/service/verifyToken.ts 41.17% 10 Missing ⚠️
...g/accounts/adaptor/repository/dummy/verifyToken.ts 66.66% 3 Missing ⚠️
pkg/accounts/service/verifyToken.test.ts 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #851      +/-   ##
==========================================
- Coverage   49.82%   49.76%   -0.06%     
==========================================
  Files         172      172              
  Lines       15855    15888      +33     
  Branches     1246     1246              
==========================================
+ Hits         7899     7906       +7     
- Misses       7956     7982      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/accounts/model/repository.ts Show resolved Hide resolved
pkg/accounts/service/verifyToken.ts Outdated Show resolved Hide resolved
pkg/accounts/adaptor/repository/prisma/prisma.ts Outdated Show resolved Hide resolved
@laminne laminne merged commit 57d543a into main Nov 28, 2024
3 of 5 checks passed
@laminne laminne deleted the feat/850-account-activation branch November 28, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: アカウントの有効化処理ができるようにする
2 participants