Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure v3.136.1 or higher codegen in all providers #1104

Closed
t0yv0 opened this issue Oct 15, 2024 · 20 comments
Closed

Ensure v3.136.1 or higher codegen in all providers #1104

t0yv0 opened this issue Oct 15, 2024 · 20 comments
Assignees
@flostadler @guineveresaenger
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Milestone
0.113

Comments

@t0yv0
Copy link
Member

t0yv0 commented Oct 15, 2024

Based on investigating pulumi/pulumi-aws#4641 it is possible to get a "pulumi.runtime.invokeOutput is not a function" error from providers that utilize codgen lower than v3.136.1 (the issue got fixed in pulumi/pulumi#17501).

We need to make sure the released providers are using the fixed version of codegen or higher.
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Oct 15, 2024
@t0yv0
Copy link
Member Author

t0yv0 commented Oct 15, 2024

https://github.com/pulumi/ci-mgmt/blob/master/scripts/monitor_versions.sh#L1 running this script to tabulate.

@t0yv0
Copy link
Member Author

t0yv0 commented Oct 15, 2024

All the bridged providers with lower versions of codegen include:

| P                     | rel     | br      | pf      | pkg      | sdk      |
|-----------------------+---------+---------+---------+----------+----------|
| pulumi-aiven          | v6.26.0 | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-alicloud       | v3.63.0 | v3.91.1 | NA      | v3.133.0 | v3.133.0 |
| pulumi-archive        | v0.2.1  | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-artifactory    | v8.1.0  | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-aws            | v6.55.0 | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-azuredevops    | v3.3.0  | v3.89.1 | NA      | v3.129.0 | v3.129.0 |
| pulumi-civo           | v2.4.4  | v3.90.0 | NA      | v3.130.0 | v3.130.0 |
| pulumi-cloudamqp      | v3.20.0 | v3.89.1 | NA      | v3.129.0 | v3.129.0 |
| pulumi-cloudflare     | v5.40.1 | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-cloudinit      | v1.4.7  | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-confluentcloud | v2.5.0  | v3.91.1 | NA      | v3.133.0 | v3.133.0 |
| pulumi-consul         | v3.12.1 | v3.89.1 | NA      | v3.129.0 | v3.129.0 |
| pulumi-databricks     | v1.51.0 | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-datadog        | v4.34.0 | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-dbtcloud       | v0.1.20 | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-digitalocean   | v4.33.0 | v3.91.1 | NA      | v3.133.0 | v3.133.0 |
| pulumi-dnsimple       | v4.1.2  | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-docker         | v4.5.6  | v3.91.1 | NA      | v3.133.0 | v3.133.0 |
| pulumi-ec             | v0.10.2 | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-external       | v0.0.9  | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-f5bigip        | v3.17.4 | v3.90.0 | NA      | v3.130.0 | v3.130.0 |
| pulumi-fastly         | v8.12.0 | v3.91.1 | NA      | v3.133.0 | v3.133.0 |
| pulumi-gcp            | v8.5.0  | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-gitlab         | v8.4.1  | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-hcloud         | v1.20.4 | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-http           | v0.0.8  | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-ise            | v0.1.7  | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-junipermist    | v0.0.27 | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-kafka          | v3.8.0  | v3.89.1 | NA      | v3.129.0 | v3.129.0 |
| pulumi-keycloak       | v5.3.4  | v3.91.0 | NA      | v3.133.0 | v3.133.0 |
| pulumi-kong           | v4.5.5  | v3.90.0 | NA      | v3.130.0 | v3.130.0 |
| pulumi-libvirt        | v0.5.0  | v3.91.0 | NA      | v3.133.0 | v3.133.0 |
| pulumi-linode         | v4.28.1 | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-local          | v0.1.4  | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-mailgun        | v3.5.5  | v3.90.0 | NA      | v3.130.0 | v3.130.0 |
| pulumi-meraki         | v0.3.2  | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-mongodbatlas   | v3.20.1 | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-mysql          | v3.2.6  | v3.90.0 | NA      | v3.130.0 | v3.130.0 |
| pulumi-null           | v0.0.7  | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-okta           | v4.11.1 | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-onelogin       | v0.6.6  | v3.91.0 | NA      | v3.133.0 | v3.133.0 |
| pulumi-openstack      | v5.0.0  | v3.91.1 | NA      | v3.133.0 | v3.133.0 |
| pulumi-opsgenie       | v1.3.11 | v3.91.1 | NA      | v3.133.0 | v3.133.0 |
| pulumi-postgresql     | v3.12.1 | v3.91.1 | NA      | v3.133.0 | v3.133.0 |
| pulumi-rabbitmq       | v3.3.6  | v3.91.1 | NA      | v3.133.0 | v3.133.0 |
| pulumi-rancher2       | v7.1.1  | v3.91.1 | NA      | v3.133.0 | v3.133.0 |
| pulumi-random         | v4.16.6 | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-rke            | v3.4.3  | v3.91.1 | NA      | v3.133.0 | v3.133.0 |
| pulumi-scm            | v0.1.5  | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-sdwan          | v0.1.3  | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-signalfx       | v7.2.2  | v3.91.1 | NA      | v3.133.0 | v3.133.0 |
| pulumi-slack          | v0.4.8  | v3.91.1 | NA      | v3.133.0 | v3.133.0 |
| pulumi-splunk         | v1.2.10 | v3.90.0 | NA      | v3.130.0 | v3.130.0 |
| pulumi-spotinst       | v3.97.0 | v3.91.1 | NA      | v3.133.0 | v3.133.0 |
| pulumi-sumologic      | v0.23.5 | v3.91.1 | NA      | v3.133.0 | v3.133.0 |
| pulumi-tailscale      | v0.17.2 | v3.91.1 | NA      | v3.133.0 | v3.133.0 |
| pulumi-tls            | v5.0.8  | v3.91.1 | v0.44.1 | v3.133.0 | v3.133.0 |
| pulumi-venafi         | v1.10.3 | v3.91.1 | NA      | v3.133.0 | v3.133.0 |
| pulumi-vsphere        | v4.11.4 | v3.91.1 | NA      | v3.133.0 | v3.133.0 |
| pulumi-wavefront      | v3.1.4  | v3.91.0 | NA      | v3.133.0 | v3.133.0 |

@t0yv0
Copy link
Member Author

t0yv0 commented Oct 15, 2024 •
edited by blampe
Loading

Native providers, I think this is the manual analysis:

  • azure-native
    github.com/pulumi/pulumi/pkg/v3 v3.135.0 <-- affected

  • kubernetes
    master is fine but is not released, last release:
    github.com/pulumi/pulumi/pkg/v3 v3.130.0     fixed

  • aws-apigateway
    affected

  • aws-native

  • awsx
    affected

  • command
    affected

  • docker-build
    master fixed but v0.0.6 affected     fixed

  • eks
    Uses github.com/pulumi/pulumi/pkg/v3 v3.129.0 but it does not matter for Node.
    Need to special-case this one.

  • google-native
    github.com/pulumi/pulumi/pkg/v3 v3.121.0
    affected

  • kubernetes-cert-manager
    affected     fixed

@mjeffryes
Copy link
Member

bridged providers just need to pick up the latest bridge upgrade Release v3.92.0 · pulumi/pulumi-terraform-bridge

@mjeffryes
Copy link
Member

google-native
github.com/pulumi/pulumi/pkg/v3 v3.121.0
affected

I think v3.121.0 predates this problem?

@t0yv0
Copy link
Member Author

t0yv0 commented Oct 15, 2024

Ah yes. Bridge updates will fix their master branch but not release them. Good point on 3.121.0 if we could find which versions are affected we might find that some old versions are not affected and we can ignore those.

This was referenced Oct 15, 2024
Closed
Closed
@t0yv0
Copy link
Member Author

t0yv0 commented Oct 15, 2024

Tier 1 is fixed and released for bridged providers. For natives, opened issues for Tier 1.

@t0yv0 t0yv0 mentioned this issue Oct 15, 2024
Open
@guineveresaenger guineveresaenger added kind/engineering Work that is not visible to an external user and removed needs-triage Needs attention from the triage team labels Oct 16, 2024
@guineveresaenger
Copy link
Contributor

Slight correction here: Bridged providers will release at least every ~8/9 weeks: https://github.com/pulumi/upgrade-provider/blob/main/upgrade/steps.go#L263.

I will go ahead and trigger patch releases for all bridged providers not on latest bridge.
I also filed #1106 as an additional enhancement.

@guineveresaenger guineveresaenger self-assigned this Oct 16, 2024
@guineveresaenger
Copy link
Contributor

Updated all bridged providers on the above list to latest bridge. Patch releases are building.

From the bridged provider perspective, we are done here; we can close out when native provider issues are resolved.

@flostadler
Copy link
Contributor

I'm working on updating the rest of the aws providers (aws-native, awsx, eks, apigateway)

This was referenced Oct 17, 2024
Closed
Closed
Closed
@t0yv0
Copy link
Member Author

t0yv0 commented Oct 31, 2024

We need to revisit the AWS-dependent provider upgrades to ensure it's on https://github.com/pulumi/pulumi-aws/releases/tag/v6.57.0 which fixes a number of issues including this one.

@t0yv0
Copy link
Member Author

t0yv0 commented Nov 7, 2024

https://github.com/pulumi/pulumi-awsx/releases/tag/v2.17.0 awsx got taken care of.

@t0yv0
Copy link
Member Author

t0yv0 commented Nov 12, 2024

@flostadler PTAL 🙏

This was referenced Nov 13, 2024
Merged
Merged
flostadler added a commit to pulumi/pulumi-aws-apigateway that referenced this issue Nov 13, 2024
@flostadler
Upgrade pulumi/pulumi to 3.138.0 (#170)
9190bf9 
This change upgrades pulumi/pulumi to 3.138.0 and upgrades AWS to 6.59.1

Relates to pulumi/ci-mgmt#1104
flostadler added a commit to pulumi/pulumi-eks that referenced this issue Nov 13, 2024
@flostadler
Upgrade pulumi/pulumi to 3.138.0 (#1486)
0bbae2f 
This change upgrades pulumi/pulumi to 3.138.0

Relates to pulumi/ci-mgmt#1104
@flostadler
Copy link
Contributor

@t0yv0 EKS and api gateway are also done now

@t0yv0
Copy link
Member Author

t0yv0 commented Nov 13, 2024

And aws-native?

@t0yv0
Copy link
Member Author

t0yv0 commented Nov 13, 2024

I think that one and Command and we can close.

@t0yv0
Copy link
Member Author

t0yv0 commented Nov 13, 2024

I'll look into command.

@t0yv0
Copy link
Member Author

t0yv0 commented Nov 13, 2024

pulumi/pulumi-command#555

@mjeffryes mjeffryes added this to the 0.113 milestone Nov 13, 2024
@t0yv0
Copy link
Member Author

t0yv0 commented Nov 14, 2024

aws-native is on v3.138.0

@t0yv0
Copy link
Member Author

t0yv0 commented Nov 14, 2024

I think this is done.

@t0yv0 t0yv0 added the resolution/fixed This issue was fixed label Nov 14, 2024
@t0yv0 t0yv0 closed this as completed Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flostadler flostadler

@guineveresaenger guineveresaenger

Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.113
Development

No branches or pull requests
5 participants
@t0yv0 @mjeffryes @flostadler @guineveresaenger @pulumi-bot