Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Run preTest actions during release verification workflow" #1276

Closed

Conversation

danielrbradley
Copy link
Member

@danielrbradley danielrbradley commented Jan 10, 2025

Reverts #1274

This caused a P1 in the pulumi-azure provider:

We can revisit an alternative way of setting up required credentials for AWS. See: #1274 (comment)

@danielrbradley danielrbradley self-assigned this Jan 10, 2025
@danielrbradley danielrbradley requested review from iwahbe and a team January 10, 2025 08:52
danielrbradley added a commit to pulumi/pulumi-azure that referenced this pull request Jan 10, 2025
iwahbe added a commit to pulumi/pulumi-junipermist that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/`
directory, we get a maintained test script and avoid overloading the `actions.preTest`
hook to run tests.

Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-scm that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/`
directory, we get a maintained test script and avoid overloading the `actions.preTest`
hook to run tests.

Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-meraki that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/`
directory, we get a maintained test script and avoid overloading the `actions.preTest`
hook to run tests.

Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-sdwan that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/`
directory, we get a maintained test script and avoid overloading the `actions.preTest`
hook to run tests.

Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-ise that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/`
directory, we get a maintained test script and avoid overloading the `actions.preTest`
hook to run tests.

Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-dbtcloud that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/`
directory, we get a maintained test script and avoid overloading the `actions.preTest`
hook to run tests.

Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-harness that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/`
directory, we get a maintained test script and avoid overloading the `actions.preTest`
hook to run tests.

Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-artifactory that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/`
directory, we get a maintained test script and avoid overloading the `actions.preTest`
hook to run tests.

Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-pagerduty that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/`
directory, we get a maintained test script and avoid overloading the `actions.preTest`
hook to run tests.

Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-okta that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/`
directory, we get a maintained test script and avoid overloading the `actions.preTest`
hook to run tests.

Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-meraki that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/`
directory, we get a maintained test script and avoid overloading the `actions.preTest`
hook to run tests.

Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-dbtcloud that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/`
directory, we get a maintained test script and avoid overloading the `actions.preTest`
hook to run tests.

Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-tailscale that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/`
directory, we get a maintained test script and avoid overloading the `actions.preTest`
hook to run tests.

Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-auth0 that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/`
directory, we get a maintained test script and avoid overloading the `actions.preTest`
hook to run tests.

Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-datadog that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/`
directory, we get a maintained test script and avoid overloading the `actions.preTest`
hook to run tests.

Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-tailscale that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in
the `provider/` directory, we get a maintained test script and avoid
overloading the `actions.preTest` hook to run tests.

Related to pulumi/ci-mgmt#1276,
pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-vault that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/`
directory, we get a maintained test script and avoid overloading the `actions.preTest`
hook to run tests.

Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-okta that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in
the `provider/` directory, we get a maintained test script and avoid
overloading the `actions.preTest` hook to run tests.

Related to pulumi/ci-mgmt#1276,
pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-gitlab that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/`
directory, we get a maintained test script and avoid overloading the `actions.preTest`
hook to run tests.

Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-postgresql that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/`
directory, we get a maintained test script and avoid overloading the `actions.preTest`
hook to run tests.

Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-snowflake that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in
the `provider/` directory, we get a maintained test script and avoid
overloading the `actions.preTest` hook to run tests.

Related to pulumi/ci-mgmt#1276,
pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-newrelic that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in
the `provider/` directory, we get a maintained test script and avoid
overloading the `actions.preTest` hook to run tests.

Related to pulumi/ci-mgmt#1276,
pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-auth0 that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in
the `provider/` directory, we get a maintained test script and avoid
overloading the `actions.preTest` hook to run tests.

Related to pulumi/ci-mgmt#1276,
pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-hcloud that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/`
directory, we get a maintained test script and avoid overloading the `actions.preTest`
hook to run tests.

Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-cloudflare that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/`
directory, we get a maintained test script and avoid overloading the `actions.preTest`
hook to run tests.

Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-vault that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in
the `provider/` directory, we get a maintained test script and avoid
overloading the `actions.preTest` hook to run tests.

Related to pulumi/ci-mgmt#1276,
pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-datadog that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in
the `provider/` directory, we get a maintained test script and avoid
overloading the `actions.preTest` hook to run tests.

Related to pulumi/ci-mgmt#1276,
pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-postgresql that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in
the `provider/` directory, we get a maintained test script and avoid
overloading the `actions.preTest` hook to run tests.

Related to pulumi/ci-mgmt#1276,
pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-gitlab that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in
the `provider/` directory, we get a maintained test script and avoid
overloading the `actions.preTest` hook to run tests.

Related to pulumi/ci-mgmt#1276,
pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-hcloud that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in
the `provider/` directory, we get a maintained test script and avoid
overloading the `actions.preTest` hook to run tests.

Related to pulumi/ci-mgmt#1276,
pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-digitalocean that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/`
directory, we get a maintained test script and avoid overloading the `actions.preTest`
hook to run tests.

Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-cloudflare that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in
the `provider/` directory, we get a maintained test script and avoid
overloading the `actions.preTest` hook to run tests.

Related to pulumi/ci-mgmt#1276,
pulumi/ci-mgmt#1274 (comment)
iwahbe added a commit to pulumi/pulumi-digitalocean that referenced this pull request Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in
the `provider/` directory, we get a maintained test script and avoid
overloading the `actions.preTest` hook to run tests.

Related to pulumi/ci-mgmt#1276,
pulumi/ci-mgmt#1274 (comment)
@danielrbradley
Copy link
Member Author

All usages have been fixed instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant