Update Makefile detection of java version #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cloudflare for demo purposes
Test Workflows show that setting `javaGenVersion` in ci-mgmt config results in this option being passed to the upgrade-provider Workflow. Not setting it removes `javaGen` from upgrade config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #506, we are setting the Java version in a provider-level version file, acting as our "lockfile".
This PR mainly updates the provider Makefiles to be in sync with the changes propagated with the latest (and hopefully last) bulk Java upgrade. Sample update here. The rollout has been a bit messy; there are currently failing updates in a few providers. They should clear up as soon as this change is merged.