Fix a panic due to non-primitive defaults #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 79.37% 79.45% +0.08%
==========================================
Files 17 17
Lines 737 740 +3
==========================================
+ Hits 585 588 +3
Misses 88 88
Partials 64 64 ☔ View full report in Codecov by Sentry. |
This was referenced May 14, 2024
|
@blampe Thank you very much for merging a fix. This issue is very annoying. Would it be possible to release a new version of |
|
This PR has been shipped in release v1.4.0. |
This was referenced Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pulumi schema doesn't support default values for non-primitive types -- objects and arrays, specifically.
This PR fixes the panic by only setting a default value when the object is primitive.
Fixes #61.
Fixes #68.
Fixes #125.
Fixes #105.