Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS page updates for reinvent 2024 #13400

Merged
merged 14 commits into from
Nov 27, 2024
Merged

AWS page updates for reinvent 2024 #13400

merged 14 commits into from
Nov 27, 2024

Conversation

shughes26
Copy link
Contributor

Proposed changes

Content now contained in markdown in aws.md, layout changes still WIP

Unreleased product version (optional)

Related issues (optional)

@shughes26 shughes26 requested a review from aaronkao November 20, 2024 19:27
@pulumi-bot
Copy link
Collaborator

Your site preview for commit 95f40e3 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13400-95f40e37.s3-website.us-west-2.amazonaws.com.

@aaronkao
Copy link
Contributor

Here are some comments from my original video that still need to be addressed + a few new ones:

  • The partner network tag, needs to find a less intrusive and bad looking place
  • There is a blue bar underneath the terminal
  • The terminal's red, yellow, and green mac window icons seem to be off in color.
  • Case studies links aren't fixed
  • Kubernetes page case study links need to be fixed as well
  • Please add BMW, Unity, and Starburst for case studies
  • The Getting started section has way too much padding. The boxes are just really big

image

aaronkao
aaronkao reviewed Nov 20, 2024
View reviewed changes
layouts/partner/aws.html Outdated Show resolved Hide resolved
@aaronkao
Copy link
Contributor

The animation in Build and Deploy, can we merge the two together? We need to change the 2nd section out to Secure, but I don't want to lose the nice animation for the pulumi up

@aaronkao aaronkao changed the title pull aws page content into markdown, templatize html AWS page updates for reinvent 2024 Nov 20, 2024
@pulumi-bot
Copy link
Collaborator

Your site preview for commit fdc631e is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13400-fdc631e0.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 566fd7a is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13400-566fd7a3.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 7e5e8c6 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13400-7e5e8c6c.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 52fe20e is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13400-52fe20e8.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit c281636 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13400-c281636f.s3-website.us-west-2.amazonaws.com.

aaronkao
aaronkao reviewed Nov 26, 2024
View reviewed changes
layouts/partner/aws.html Outdated Show resolved Hide resolved
layouts/partner/aws.html
<img class="shadow-xl rounded" src="https://www.pulumi.com/uploads/content/blog/automation-api/http.gif" alt="Pulumi over HTTP" />
<!-- {{ partial "code" (dict "code" .Params.automation_api_code "lang" "js" "mode" "dark" "chrome" true) }} -->
<div class="w-full mt-8 lg:mt-0 lg:w-7/12">
<img class="shadow-xl rounded" src="https://www.pulumi.com/uploads/content/blog/automation-api/http.gif" alt="Pulumi over HTTP" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there needs to be some white space above this gif. Will need to replace the gif as well. What dimension should this be?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

896px height by 447px width

layouts/partner/aws.html Show resolved Hide resolved
layouts/partials/home/cli.html Show resolved Hide resolved
layouts/partials/home/ide.html Show resolved Hide resolved
content/partner/aws.md Show resolved Hide resolved
@pulumi-bot
Copy link
Collaborator

Your site preview for commit 2d9e784 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13400-2d9e784d.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 69a84e9 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13400-69a84e94.s3-website.us-west-2.amazonaws.com.

aaronkao
aaronkao reviewed Nov 27, 2024
View reviewed changes
content/partner/aws.md
link: /case-studies/unity
logo: /logos/customers/unity.png
- name: Starburst
link: /case-studies/starburst
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think starburst shouldn't be the only one on the 2nd row. We should move like BMW and Unity down as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logos wrap individually, I'll come back to this if I've got some extra time later to see if I can get them to wrap in groups or something

@thtmnisamnstr
Copy link
Contributor

  • On the images under the Secure and Manage sections, there is a white buffer on the right side that should be transparent.
  • In the Automate section, on the bottom row of the 2x3 grid, swap the Full Coverage of AWS cell w/ the Continuous delivery for infrastructure cell. Also remove the period from the subheading.
  • In the Secure section, in the Stop Secrets Sprawl cell, change the copy to "Pull and sync secrets and configuration with any secrets store – AWS Secrets Manager, HashiCorp Vault, and more – and consume in any application, tool, or CI/CD platform."
  • In the Manage section, remove the period from the subheading.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 79596fa is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13400-79596fae.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 58ac38d is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13400-58ac38d8.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 87c22bd is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13400-87c22bd5.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 88f4c9a is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13400-88f4c9a5.s3-website.us-west-2.amazonaws.com.

@thtmnisamnstr thtmnisamnstr merged commit 8977623 into master Nov 27, 2024
8 checks passed
@thtmnisamnstr thtmnisamnstr deleted the sarah/aws-update branch November 27, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronkao aaronkao aaronkao left review comments

@thtmnisamnstr thtmnisamnstr thtmnisamnstr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shughes26 @pulumi-bot @aaronkao @thtmnisamnstr