Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): add docs for creating insights accounts #13457

Merged
merged 24 commits into from
Dec 2, 2024

Conversation

tyler-dunkel
Copy link
Contributor

@tyler-dunkel tyler-dunkel commented Nov 27, 2024

Proposed changes

Adds new docs for the new accounts feature for insights 2.0

Unreleased product version (optional)

Related issues (optional)

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@tyler-dunkel tyler-dunkel changed the title feat(insights): add first draft of docs for creating insights accounts feat(insights): add docs for creating insights accounts Nov 29, 2024
@tyler-dunkel tyler-dunkel marked this pull request as ready for review November 29, 2024 18:42
@tyler-dunkel tyler-dunkel requested a review from a team as a code owner November 29, 2024 18:42
@pulumi-bot
Copy link
Collaborator

Copy link
Collaborator

@interurban interurban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding an approval so you can ship, I'll give it a deeper walk through on monday when I'm back in town.

Co-authored-by: James Denyer <james.denyer@gmail.com>
Co-authored-by: James Denyer <james.denyer@gmail.com>
@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@tyler-dunkel tyler-dunkel merged commit 84b7786 into master Dec 2, 2024
6 checks passed
@tyler-dunkel tyler-dunkel deleted the tyler/insights-docs branch December 2, 2024 19:00
OCI_TENANCY_OCID: "ocid1.tenancy.oc1..tenancyidnumbers"
OCI_USER_OCID: "user_ocid"
files:
OCI_PRIVATE_KEY: "PRIVATE_KEY_CONTENT"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be OCI_PRIVATE_KEY_PATH. Fix is in #13481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants