Update README.md to steer toward pulumitest #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This repo is weird in that there's essentially a new and improved version in the pulumitest directory, but the older providertest code is still available in the top level (and used in some older providers tests). We need to clarify this in the README, so that users (internal and external) don't end up trying to write more tests that depend on providertest rather than pulumitest.
iwahbe
approved these changes
Jan 24, 2025
|
We should really remove the other one. |
Co-authored-by: Ian Wahbe <ian@wahbe.com>
I heartily agree, do we have a sense how many providers are depending on the old one? |
|
https://github.com/search?q=org%3Apulumi+WithProviderName&type=code I think only DockerBuild. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repo is weird in that there's essentially a new and improved version in the pulumitest directory, but the older providertest code is still available in the top level (and used in some older providers tests).
We need to clarify this in the README, so that users (internal and external) don't end up trying to write more tests that depend on providertest rather than pulumitest.