Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: update internal pulumi dependencies" #1859

Closed
wants to merge 1 commit into from

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Nov 26, 2024

Reverts #1853

It appears that the changes inadvertently caused #1855 due to interaction with legacy pulumi/scripts. We might need to modernize the build scripts first before proceeding further.

Fixes #1855

Copy link
Contributor

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.97%. Comparing base (13218e8) to head (8dc0c0d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1859      +/-   ##
==========================================
+ Coverage   49.27%   49.97%   +0.69%     
==========================================
  Files          46       44       -2     
  Lines        6796     6702      -94     
==========================================
  Hits         3349     3349              
+ Misses       3204     3110      -94     
  Partials      243      243              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@blampe blampe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively you can try reverting just the workflow portion. I just made a change to have Renovate stop managing that until we sort out how to make it play nicely with ci-mgmt

@t0yv0
Copy link
Member Author

t0yv0 commented Nov 26, 2024

Ah that's nice yeah I'll go for that.

@t0yv0 t0yv0 closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow failure: build
2 participants