Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize Makefile to ci-mgmt #2756

Closed
iwahbe opened this issue Aug 29, 2023 · 1 comment
Closed

Normalize Makefile to ci-mgmt #2756

iwahbe opened this issue Aug 29, 2023 · 1 comment
Assignees
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Milestone

Comments

@iwahbe
Copy link
Member

iwahbe commented Aug 29, 2023

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

pulumi-aws currently uses a bespoke Makefile. To simplify use and allow automated upgrades, we should convert to a Makefile generated by ci-mgmt.

This involves switching upstream to a patch managed system, as opposed to a fork managed one. The important part of this PR is that the upgrade process looks just like a normal bridged provider, and that we can automate with upgrade-provider.

To accommodate for the special behavior still needed by pulumi-aws (specifically running upstream-tools), we can add a hook system to the generated Makefile and import a local Makefile (if it exists). The goal here is to keep any pulumi-aws specific Make targets in the pulumi-aws repo without breaking the build.

Related: pulumi/ci-mgmt#518 disabled Makefile generation for pulumi-aws. As part of closing this issue, we should undo this commit.

Like #2708, the PR that closes this issue will need to be duplicated in pulumi-aws and ci-mgmt.

Affected area/feature

The Makefile.

@iwahbe iwahbe added kind/enhancement Improvements or new features kind/engineering Work that is not visible to an external user and removed kind/enhancement Improvements or new features labels Aug 29, 2023
@guineveresaenger guineveresaenger self-assigned this Aug 30, 2023
@mikhailshilkov mikhailshilkov added this to the 0.94 milestone Sep 1, 2023
@guineveresaenger guineveresaenger added the resolution/fixed This issue was fixed label Sep 11, 2023
@guineveresaenger
Copy link
Contributor

Closing as done via both linked PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

3 participants