Generate workflows for aws #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
iwahbe
force-pushed
the
iwahbe/ci-mgmt-for-pulumi-aws
branch
2 times, most recently
from
47a0565
to
baa0f50
Compare
18 tasks
iwahbe
requested review from
t0yv0
and removed request for
a team,
t0yv0 and
danielrbradley
iwahbe
force-pushed
the
iwahbe/ci-mgmt-for-pulumi-aws
branch
8 times, most recently
from
8786cf6
to
8ec6279
Compare
We missed updating this when we removed `.Config.actionVersions.setupGo` to `.Config.actions.setupGo`. These workflows were broken, and this fixes them.
iwahbe
force-pushed
the
iwahbe/ci-mgmt-for-pulumi-aws
branch
from
8ec6279
to
a9bb324
Compare
iwahbe
force-pushed
the
iwahbe/ci-mgmt-for-pulumi-aws
branch
from
a9bb324
to
0e7a98d
Compare
iwahbe
added a commit
to pulumi/pulumi-aws
that referenced
this pull request
Aug 25, 2023
This relies on pulumi/ci-mgmt@fa795bc and pulumi/ci-mgmt@727247e from pulumi/ci-mgmt#518.
There was a problem hiding this comment.
This looks great at first glance.
Can you add an explanation why we need the extraTests config option? I'm assuming it's because we want to test the provider shim in AWS but nowhere else - however I don't see an extra shim test action being generated; what am I missing?
iwahbe
commented
Aug 26, 2023
Comment on lines
+370
to
+388
| go_test_shim: | ||
| if: github.event_name == 'repository_dispatch' || github.event.pull_request.head.repo.full_name == github.repository | ||
| name: Run test of provider shim | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout Repo | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| ref: ${{ env.PR_COMMIT_SHA }} | ||
| submodules: true | ||
| - uses: actions/setup-go@v4 | ||
| with: | ||
| cache-dependency-path: provider/shim/go.sum | ||
| go-version-file: provider/shim/go.mod | ||
| - name: go test | ||
| run: | | ||
| cd provider/shim | ||
| go test -v . | ||
| timeout-minutes: 60 |
There was a problem hiding this comment.
This looks great at first glance.
Can you add an explanation why we need the
extraTestsconfig option? I'm assuming it's because we want to test the provider shim in AWS but nowhere else - however I don't see an extra shim test action being generated; what am I missing?
You're right, we use extraTests for testing the shim. Each item in extraTests is instantiated wherever we do tests (run-acceptance-tests.yml, master.yml, main.yml, prerelease.yml and release.yml), and then back-linked as a needs dependency wherever other tests are linked.
iwahbe
added a commit
to pulumi/pulumi-aws
that referenced
this pull request
Aug 28, 2023
…2708) This PR is based off of pulumi/ci-mgmt#518. The Makefile has greater changes, which will be handled in a separate PR. There are outstanding changes in these files: - [ ] Makefile - [x] .github/workflows/main.yml - [x] .github/workflows/master.yml - [x] .github/workflows/nightly-test.yml - [x] .github/workflows/prerelease.yml - [x] .github/workflows/release.yml - [x] .github/workflows/run-acceptance-tests.yml - [x] .github/workflows/update-bridge.yml - [X] .github/workflows/command-dispatch.yml - [X] .github/workflows/community-moderation.yml - [X] .github/workflows/pull-request.yml - [X] .github/workflows/resync-build.yml - [X] .github/workflows/upgrade-bridge.yml - [X] .github/workflows/upgrade-provider.yml - [X] .goreleaser.prerelease.yml - [X] .goreleaser.yml - [X] .upgrade-config.yml - [X] scripts/upstream.sh We will merge as soon as we release v6. I expect the Makefile normalization to occur later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generated the workflow files for pulumi/pulumi-aws#2708.
This does not account for aws's Makefile, which is still non-standard. To make this safe to merge, we skip generating a Makefile for pulumi-aws (leaving the current one in place).
Improvements to ci-mgmt:
We are waiting to merge until aws v6 has launched.v6 has launched and we have updated pulumi-aws's workflows. Merging now.