Upgrade terraform-provider-aws to v5.20.1 #2870
Conversation
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
Maintainer note: consult the runbook for dealing with any breaking changes. |
| }, | ||
| { | ||
| "old": "Using `terraform import`, import Verified Access Instance Trust Provider Attachments using the `verifiedaccess_instance_id` and `verifiedaccess_trust_provider_id` separated by a forward slash (`/`). For example:", | ||
| "new": "Using `TODO import`, import Verified Access Instance Trust Provider Attachments using the `verifiedaccess_instance_id` and `verifiedaccess_trust_provider_id` separated by a forward slash (`/`). For example:" |
There was a problem hiding this comment.
I think we're supposed to edit these TODO things by hand to say something sensible about pulumi imports. Unfortunate but remains a chore here. I've done this N=1 times so not exactly sure.
There was a problem hiding this comment.
Good catch. TODO is not descriptive, and should be updated to something like Pulumi. Will address in a follow-up commit to this PR soon.
There was a problem hiding this comment.
Hmm, looks like we have 608 TODOs within this file, spanning back to many months ago. WDYT if we submit this PR as is, and I'll create a follow-up PR to directly handle these TODOs before cutting a new release?
There was a problem hiding this comment.
Err. Yea could you backlog an item to clean this up? When doing that instead of cleaning up by hand we could improve the tooling not to require this. One place to check would be looking at registry docs for a resource with the TODO, if TODO renders in registry that's a clear indicator this is user-facing in a way.
|
LGTM except those TODOs, looks like a small clean update. |
This PR was generated via
$ upgrade-provider pulumi/pulumi-aws --upstream-provider-name=terraform-provider-aws --kind=provider.Fixes Upgrade terraform-provider-aws to v5.20.1 #2869
Fixes Upgrade terraform-provider-aws to v5.20.0 #2860