Fixes inability to tag AWS Firehose stream #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/release patch |
github-actions
bot
added
the
needs-release/patch
|
Missed "fmt" import in the patch, trying again. |
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
github-actions
bot
removed
the
needs-release/patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3064
There is an issue with users being unable to add tags to AWS Firehose delivery stream and select other resources.
As part of the #2944 mitigation the provider needs to make sure that tags_all attributes, if present, are not Computed because pulumi-aws will set them before passing down to TF code.
TestTagsAllNoLongerComputed was supposed to check this.
Unfortunately the transformation missed that some resources define SchemaFunc instead of Schema, and so did the test. The test is made stricter here, and the underlying transformation is fixed.