expose route table ids #885
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Route table ids can be important for VPCs after they've been created. Exposing the route table ids as outputs allows us to easily support resources like NAT instances (cheaper than NAT Gateways), AWS Transit Gateways and AWS Client VPNs
|
@danielrbradley am I missing something here? I generated the types locally so trying to understand the failures here |
Comment on lines
+1692
to
+1709
| "publicRouteTableIds": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "privateRouteTableIds": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "isolatedRouteTableIds": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "string" | ||
| } | ||
| }, |
There was a problem hiding this comment.
The schema.json is generated by the schemagen program. The VPC types are defined using this code here: https://github.com/pulumi/pulumi-awsx/blob/master/schemagen/pkg/gen/ec2.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Route table ids can be important for VPCs after they've been created.
Exposing the route table ids as outputs allows us to easily support resources like NAT instances (cheaper than NAT Gateways), AWS Transit Gateways and AWS Client VPNs