Get Azure Blobs example working #2
Conversation
We can use the built-in `azure.storage.getAccountSAS` to compute SAS URLs instead of making calls out to the Azure SDK at deployment time.
| const connectionString = (bindings[0] as any).connection; | ||
| const appSettings: Record<string, string> = {}; | ||
| if (connectionString) { | ||
| (bindings[0] as any).connection = "FOO"; |
There was a problem hiding this comment.
See PR summary:
The mapping of connection string into app settings + bindings.json is a little hacky - ideally the BlobBinding datastructure would be the real schema for the bindings instead of having to rewrite it as this code does.
| })); | ||
| map[`${name}/index.js`] = new pulumi.asset.StringAsset(`module.exports = require("./handler").handler`), | ||
| map[`${name}/handler.js`] = new pulumi.asset.StringAsset(serializedHandler.text); | ||
| // TODO: Include only the package depdencies that are referenced, similar to aws.serverless.Function |
| @@ -151,7 +136,7 @@ export class EventSubscription<C extends Context, Data> extends pulumi.Component | |||
| args = args || {}; | |||
|
|
|||
| this.resourceGroup = args.resourceGroup || new azure.core.ResourceGroup(`${name}`, { | |||
| location: region, | |||
| location: "West US", | |||
There was a problem hiding this comment.
See comment in PR summary:
The hard-coding of West US is bad. I actually think we should get rid of the "automatically create a ResourceGroup" code paths here, and make users pass resource group down through all abstractions for now. It's ugly, but consistent with all other Azure APIs. If we're going to solve for that - we should likely do it in some deeper way.
|
|
||
| const blob = new azure.storage.ZipBlob(`${name}`, { | ||
| resourceGroupName: this.resourceGroup.name, | ||
| storageAccountName: this.storageAccount.name, | ||
| storageContainerName: this.storageContainer.name, | ||
| type: "block", | ||
|
|
||
| content: assetMap.apply(m => new pulumi.asset.AssetArchive(m)), | ||
| // TODO: https://github.com/pulumi/pulumi-terraform/issues/191 | ||
| content: new pulumi.asset.AssetArchive((assetMap as any).promise()), |
There was a problem hiding this comment.
interesting. why does Output<AssetArchive> not work... the underlying resource code should unwrap the Output, then handle the archive... right?
There was a problem hiding this comment.
Not sure - I assume just a bug somewhere - pulumi/pulumi-terraform#191 is tracking fixing the bug.
|
@CyrusNajmabadi Let me know if you want to take this and address the three "lingering issues" noted in the PR summary (plus anything else needed to get this ready to merge), or if you'd like me to. Either works for me. |
|
I'm ok with this as is. I'm going to look at trying ti figure out why outputs-of-assets+terraform aren't working properly. |
This builds on the
subscriptionbranch to finish getting Blobs working end-to-end. Opening as a PR into that branch so that @CyrusNajmabadi can take a look and integrate if needed with that existing PR.There are a few lingering issues:
Output<Archive>whenInput<Archive>is specified pulumi-terraform#191 causes initial preview to fail, to initially stand up the example apulumi update --skip-previewis required.West USis bad. I actually think we should get rid of the "automatically create a ResourceGroup" code paths here, and make users pass resource group down through all abstractions for now. It's ugly, but consistent with all other Azure APIs. If we're going to solve for that - we should likely do it in some deeper way.