Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Asset as argument to CopyFile #42

Closed
Tracked by #449
rbm-radius opened this issue Mar 2, 2022 · 2 comments · Fixed by #423
Closed
Tracked by #449

Add support for Asset as argument to CopyFile #42

rbm-radius opened this issue Mar 2, 2022 · 2 comments · Fixed by #423
Assignees
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@rbm-radius
Copy link

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Currently, CopyFile only takes strings (file system paths) as arguments to describe the local and remote files to be copied. Having support for Asset would allow CopyFile to react to changes to the file as an Asset, and would allow a file upload via CopyFile to work the same way as an upload to S3, which is the same thing conceptually.

Affected area/feature

@rbm-radius rbm-radius added the kind/enhancement Improvements or new features label Mar 2, 2022
@guineveresaenger guineveresaenger added kind/enhancement Improvements or new features and removed kind/enhancement Improvements or new features labels Mar 8, 2022
@kwohlfahrt
Copy link

+1, this would be extremely useful (especially if it can handle secrets correctly). There is a PR for this in #25, but it's gone a bit stale.

@Bessonov
Copy link

@iwahbe Probably, related to or makes #23 obsolete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
7 participants