Extend the CopyFile resource to copy directories and work with assets and archives #414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superceded by #423
This PR allows the CopyFile resource to recursively copy directories as well, similar to
scp -r
.This PR enhances the CopyFile resource in a few ways.
In light of these changes, I've renamed
CopyFile
to justCopy
.Resolves #23
Resolves #33
Resolves #42
TODO
The current implementation fails as soon as a file or directory already exists on the remote, like the previousBefore GA-ing the provider, we should think about whether users might need other behaviors and how to expose them, e.g., continue if exists or clear the whole remote destination before copying.CopyFile
.CopyFile
toCopy
orRemoteCopy
or insert your proposal here?TestEc2RemoteTs
, which we should share instead. What would be a good way to do that, given the code is in the TS tests, not in the Go driver?Design questions
Implementation notes