Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation #14

Merged
merged 5 commits into from
Dec 15, 2021
Merged

Add documentation #14

merged 5 commits into from
Dec 15, 2021

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Dec 14, 2021

Fixes #10

@iwahbe iwahbe self-assigned this Dec 14, 2021
Copy link
Contributor

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor updates to consider - but can take these as follow-ups as well.

provider/cmd/pulumi-resource-command/schema.json Outdated Show resolved Hide resolved
provider/cmd/pulumi-resource-command/schema.json Outdated Show resolved Hide resolved
provider/cmd/pulumi-resource-command/schema.json Outdated Show resolved Hide resolved
provider/cmd/pulumi-resource-command/schema.json Outdated Show resolved Hide resolved
@@ -71,21 +82,23 @@
],
"inputProperties": {
"interpreter": {
"description": "The program and arguments to run the command.\nFor example: `[\"/bin/sh\", \"-c\"]`",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "The program and arguments to run the command.\nFor example: `[\"/bin/sh\", \"-c\"]`",
"description": "The program and arguments to run the command.\nOn Windows, defaults to: `[\"cmd\", \"/C\"]`. On Linux and macOS, defaults to:`[\"/bin/sh\", \"-c\"]`",

@iwahbe iwahbe merged commit 03b703b into master Dec 15, 2021
@iwahbe iwahbe deleted the iwahbe/add-documentation branch December 15, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs for all public APIs
2 participants