Add Remote FileCopy #21
Conversation
| "context" | ||
| "os" | ||
|
|
||
| "github.com/pkg/sftp" |
There was a problem hiding this comment.
Curious - as I'm not certain myself yet - but was there a reason to choose sftp over scp for this?
| } | ||
|
|
||
| func (c *remotefilecopy) RunDelete(ctx context.Context, host *provider.HostClient, urn resource.URN) error { | ||
| host.Log(ctx, diag.Info, urn, "Deleting remotefilecopy") |
There was a problem hiding this comment.
I expect we don't need this?
(though we may benefit from debug level diagnostics in quite a few more places for future debuggability)
| if err := inner(); err != nil { | ||
| return "", err | ||
| } | ||
| return resource.NewUniqueHex("", 8, 0) |
There was a problem hiding this comment.
Any opportunity to add something more semantically meaningful here? I could image deriving a prefix from the remotePath potentially? But maybe more awkward than helpful?
There was a problem hiding this comment.
It would still need a random component because we might have an otherwise identical CopyFile with a different connection. I don't think there is much benefit. I think the same argument applies to remote:Command.
There was a problem hiding this comment.
Yeah - agreed. I was wondering similar for remote Command, but there's even less sensible to use there. Sticking with the random hex sounds good.
Adds a resource that represents moving a file from a local to a remote host.
Fixes #6