Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update droplets enum #867

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Update droplets enum #867

merged 4 commits into from
Nov 13, 2024

Conversation

VenelinMartinov
Copy link
Contributor

Update the droplets enum as it was last generated 3 years ago.

fixes #864

Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if this is breaking? We need to make sure that we are deprecating, not removing old droplets names.

@VenelinMartinov
Copy link
Contributor Author

Yeah, great point. I was hoping the schema check would catch breaking changes here but it didn't.

I've now verified that all the old values are still present and have added back the ones which are no longer returned in the generation command.

@VenelinMartinov VenelinMartinov enabled auto-merge (squash) November 13, 2024 13:25
@VenelinMartinov VenelinMartinov merged commit 97ab723 into master Nov 13, 2024
23 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/update_droplets_enum branch November 13, 2024 13:28
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v4.34.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synchronize DropletSlug constants
3 participants