-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update droplets enum #867
Update droplets enum #867
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if this is breaking? We need to make sure that we are deprecating, not removing old droplets names.
Yeah, great point. I was hoping the schema check would catch breaking changes here but it didn't. I've now verified that all the old values are still present and have added back the ones which are no longer returned in the generation command. |
This PR has been shipped in release v4.34.1. |
Update the droplets enum as it was last generated 3 years ago.
fixes #864