Adds a labels test matrix #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Does the PR have any schema changes?Found 145 breaking changes: Resources
Functions
Types
New resources:
Maintainer note: consult the runbook for dealing with any breaking changes. |
Co-authored-by: Ian Wahbe <ian@wahbe.com>
iwahbe
changed the base branch from
master
to
upgrade-terraform-provider-google-beta-to-v5.0.0
iwahbe
reviewed
Nov 2, 2023
examples/examples_go_test.go
Outdated
| @@ -1,15 +1,15 @@ | |||
| // Copyright 2016-2017, Pulumi Corporation. All rights reserved. | |||
| //go:build go || all | |||
| // +build go all | |||
There was a problem hiding this comment.
I think we need to put these back or our go tests will run for each language.
…ffForChanges. Re-add Go build tags to Go test file.
guineveresaenger
merged commit 788bf91
into
upgrade-terraform-provider-google-beta-to-v5.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #1238
The new release of GCP adds a DefaultLabels feature.
This change ports a test matrix from a similar feature of AWS provider. The matrix tests that for
all interesting label combinations (empty, non-empty, 0, 1, or two labels, at provider DefaultLabels
or resource Labels level), Pulumi provider can transition a sample resource from one combination to
another, and the actual effective set of labels is what you would expect.
What is currently not tested here but may need scrutiny based on similar issues in AWS:
into management under GCP; this is not tested here
The tests are currently failing likely due to a bridge issue:
pulumi/pulumi-terraform-bridge#1501