Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert delete before replace changes #2595

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Revert delete before replace changes #2595

merged 2 commits into from
Nov 8, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Nov 8, 2024 •
edited
Loading

Context:

#2596

Revert:

Affected resources:

  • google_compute_global_address
  • google_compute_instance
  • google_compute_vpn_tunnel
  • google_project_iam_member
  • google_service_account_iam_member

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@t0yv0 t0yv0 requested review from a team and rshade November 8, 2024 17:24
@t0yv0 t0yv0 enabled auto-merge (squash) November 8, 2024 17:28
@t0yv0
Copy link
Member Author

t0yv0 commented Nov 8, 2024

/release patch

@github-actions github-actions bot added the needs-release/patch When a PR with this label merges, it initiates a release of vX.Y.Z+1 label Nov 8, 2024
rshade
rshade approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@rshade rshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t0yv0 t0yv0 merged commit 4b294a0 into master Nov 8, 2024
24 checks passed
@t0yv0 t0yv0 deleted the t0yv0/revert-dbr-changes branch November 8, 2024 18:31
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v8.8.1.

@github-actions github-actions bot removed the needs-release/patch When a PR with this label merges, it initiates a release of vX.Y.Z+1 label Nov 11, 2024
@VenelinMartinov VenelinMartinov mentioned this pull request Nov 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VenelinMartinov VenelinMartinov VenelinMartinov approved these changes

@rshade rshade rshade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t0yv0 @pulumi-bot @rshade @VenelinMartinov