Skip to content

Commit

Permalink
Merge branch 'main' into use-specialized-missing-required-property-ex…
Browse files Browse the repository at this point in the history
…ception
  • Loading branch information
Zaid-Ajaj committed Oct 11, 2023
2 parents 8196203 + 353d99a commit 7d572fd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG_PENDING.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
### Improvements

- Generated SDKs use specialized `MissingRequiredPropertyException` rather than throwing `NullPointerException` when a required input property is missing.

### Bug Fixes
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public MockMonitor(Mocks mocks, Log log) {

@Override
public CompletableFuture<SupportsFeatureResponse> supportsFeatureAsync(SupportsFeatureRequest request) {
var hasSupport = "secrets".equals(request.getId()) || "resourceReferences".equals(request.getId());
var hasSupport = !"outputValues".equals(request.getId());
return CompletableFuture.completedFuture(
SupportsFeatureResponse.newBuilder().setHasSupport(hasSupport).build()
);
Expand Down

0 comments on commit 7d572fd

Please sign in to comment.