Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate workflows to fix Go SDK publish #415

Merged
merged 2 commits into from
May 9, 2024
Merged

Generate workflows to fix Go SDK publish #415

merged 2 commits into from
May 9, 2024

Conversation

danielrbradley
Copy link
Member

@danielrbradley danielrbradley self-assigned this May 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Is README.md missing any configuration options?

caCertFile not found in Configuration section
clientCertFile not found in Configuration section
clientKeyFile not found in Configuration section
clientKeyPassphrase not found in Configuration section
kafkaVersion not found in Configuration section
saslAwsCredsDebug not found in Configuration section
saslAwsProfile not found in Configuration section
saslAwsRegion not found in Configuration section
saslAwsRoleArn not found in Configuration section
saslTokenUrl not found in Configuration section

Please add a description for each of these options to README.md. Details about them can be found in either the upstream docs or schema.json.

VenelinMartinov
VenelinMartinov requested changes May 9, 2024
View reviewed changes
.github/workflows/master.yml Outdated Show resolved Hide resolved
VenelinMartinov
VenelinMartinov approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@VenelinMartinov VenelinMartinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@danielrbradley danielrbradley merged commit a751acf into master May 9, 2024
17 checks passed
@danielrbradley danielrbradley deleted the fix-go-sdk-publish branch May 9, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VenelinMartinov VenelinMartinov VenelinMartinov approved these changes

Assignees

@danielrbradley danielrbradley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workflow failure: release
2 participants
@danielrbradley @VenelinMartinov