update stacks_failing metric to check pulumiv1.Stack instead of pulumiv1alpha1.Stack #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
|
I realized this is basically a duplicate of #245, but I'm keeping this open since it's a less stale branch |
stack72
changed the title
|
/run-acceptance-tests |
|
Please view the PR build - https://github.com/pulumi/pulumi-kubernetes-operator/actions/runs/2884514361 |
viveklak
approved these changes
Aug 18, 2022
|
Thanks for the PR @bob-bins ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update
stacks_failingmetric to use the currentv1Stack API version instead of the outdatedv1alpha1.From my observations, the pulumi-k8s-operator automatically upgrades new applications of the
Stackresources tov1if they are applied with the older API version, so for newStacks it should be fine that this PR does not account for the old API version. However, I don't know if the operator converts oldStackresources to the new version so whether not this is a breaking change is not known to me right now.Related issues (optional)
#307
Additional comments
I tested this locally, but I tested it with a base branch from the 1.7.0 release commit cb9f70c instead of the latest
masterbranch because the pulumi-k8s-operator was giving me errors when attempting to checkout the git branch:unable to checkout branch: reference not foundSomehow the change in ef96c6d (specifically the change in pulumi/pulumi#10118) did not work for me for both branch formats:
refs/remotes/origin/fooandfoo.