Address feedback

pulumi · Aug 19, 2019 · 40eb038 · 40eb038
1 parent 4b6804e
commit 40eb038
Show file tree

Hide file tree

Showing 23 changed files with 50 additions and 4 deletions.
diff --git a/pkg/gen/awaitComments.go b/pkg/gen/awaitComments.go
@@ -21,7 +21,9 @@ import (
 )
 
 func timeoutComment(kind kinds.Kind) string {
-	const timeoutOverride = `setting 'pulumi.com/timeoutSeconds' as a '.metadata.annotation' on the resource.`
+	const timeoutOverride = `setting 'pulumi.com/timeoutSeconds' as a '.metadata.annotation' on the resource.
+This approach will be deprecated in favor of customTimeouts. See
+https://github.com/pulumi/pulumi-kubernetes/issues/672 for details.`
 
 	timeout := func(kind kinds.Kind) string {
 		switch kind {
@@ -86,7 +88,7 @@ Or (for Jobs): The Pod succeeded ('.status.phase' set to "Succeeded").
 	case kinds.Service:
 		comment += `
 1. Service object exists.
-2. Related Endpoint objects are created. Each time we get an update, wait ~5-10 seconds
+2. Related Endpoint objects are created. Each time we get an update, wait 10 seconds
    for any stragglers.
 3. The endpoints objects target some number of living objects (unless the Service is
    an "empty headless" Service [1] or a Service with '.spec.type: ExternalName').

diff --git a/sdk/nodejs/apps/v1/Deployment.ts b/sdk/nodejs/apps/v1/Deployment.ts
@@ -29,6 +29,8 @@ import { getVersion } from "../../version";
      * If the Deployment has not reached a Ready state after 5 minutes, it will
      * time out and mark the resource update as Failed. You can override the default timeout value
      * by setting 'pulumi.com/timeoutSeconds' as a '.metadata.annotation' on the resource.
+     * This approach will be deprecated in favor of customTimeouts. See
+     * https://github.com/pulumi/pulumi-kubernetes/issues/672 for details.
      */
     export class Deployment extends pulumi.CustomResource {
       /**

diff --git a/sdk/nodejs/apps/v1/StatefulSet.ts b/sdk/nodejs/apps/v1/StatefulSet.ts
@@ -24,6 +24,8 @@ import { getVersion } from "../../version";
      * If the StatefulSet has not reached a Ready state after 5 minutes, it will
      * time out and mark the resource update as Failed. You can override the default timeout value
      * by setting 'pulumi.com/timeoutSeconds' as a '.metadata.annotation' on the resource.
+     * This approach will be deprecated in favor of customTimeouts. See
+     * https://github.com/pulumi/pulumi-kubernetes/issues/672 for details.
      */
     export class StatefulSet extends pulumi.CustomResource {
       /**

diff --git a/sdk/nodejs/apps/v1beta1/Deployment.ts b/sdk/nodejs/apps/v1beta1/Deployment.ts
@@ -31,6 +31,8 @@ import { getVersion } from "../../version";
      * If the Deployment has not reached a Ready state after 5 minutes, it will
      * time out and mark the resource update as Failed. You can override the default timeout value
      * by setting 'pulumi.com/timeoutSeconds' as a '.metadata.annotation' on the resource.
+     * This approach will be deprecated in favor of customTimeouts. See
+     * https://github.com/pulumi/pulumi-kubernetes/issues/672 for details.
      */
     export class Deployment extends pulumi.CustomResource {
       /**

diff --git a/sdk/nodejs/apps/v1beta1/StatefulSet.ts b/sdk/nodejs/apps/v1beta1/StatefulSet.ts
@@ -26,6 +26,8 @@ import { getVersion } from "../../version";
      * If the StatefulSet has not reached a Ready state after 5 minutes, it will
      * time out and mark the resource update as Failed. You can override the default timeout value
      * by setting 'pulumi.com/timeoutSeconds' as a '.metadata.annotation' on the resource.
+     * This approach will be deprecated in favor of customTimeouts. See
+     * https://github.com/pulumi/pulumi-kubernetes/issues/672 for details.
      */
     export class StatefulSet extends pulumi.CustomResource {
       /**

diff --git a/sdk/nodejs/apps/v1beta2/Deployment.ts b/sdk/nodejs/apps/v1beta2/Deployment.ts
@@ -31,6 +31,8 @@ import { getVersion } from "../../version";
      * If the Deployment has not reached a Ready state after 5 minutes, it will
      * time out and mark the resource update as Failed. You can override the default timeout value
      * by setting 'pulumi.com/timeoutSeconds' as a '.metadata.annotation' on the resource.
+     * This approach will be deprecated in favor of customTimeouts. See
+     * https://github.com/pulumi/pulumi-kubernetes/issues/672 for details.
      */
     export class Deployment extends pulumi.CustomResource {
       /**

diff --git a/sdk/nodejs/apps/v1beta2/StatefulSet.ts b/sdk/nodejs/apps/v1beta2/StatefulSet.ts
@@ -26,6 +26,8 @@ import { getVersion } from "../../version";
      * If the StatefulSet has not reached a Ready state after 5 minutes, it will
      * time out and mark the resource update as Failed. You can override the default timeout value
      * by setting 'pulumi.com/timeoutSeconds' as a '.metadata.annotation' on the resource.
+     * This approach will be deprecated in favor of customTimeouts. See
+     * https://github.com/pulumi/pulumi-kubernetes/issues/672 for details.
      */
     export class StatefulSet extends pulumi.CustomResource {
       /**

diff --git a/sdk/nodejs/core/v1/Pod.ts b/sdk/nodejs/core/v1/Pod.ts
@@ -23,6 +23,8 @@ import { getVersion } from "../../version";
      * If the Pod has not reached a Ready state after 5 minutes, it will
      * time out and mark the resource update as Failed. You can override the default timeout value
      * by setting 'pulumi.com/timeoutSeconds' as a '.metadata.annotation' on the resource.
+     * This approach will be deprecated in favor of customTimeouts. See
+     * https://github.com/pulumi/pulumi-kubernetes/issues/672 for details.
      */
     export class Pod extends pulumi.CustomResource {
       /**

diff --git a/sdk/nodejs/core/v1/Service.ts b/sdk/nodejs/core/v1/Service.ts
@@ -16,7 +16,7 @@ import { getVersion } from "../../version";
      * The following conditions are used to determine whether the resource creation has
      * succeeded or failed:
      * 1. Service object exists.
-     * 2. Related Endpoint objects are created. Each time we get an update, wait ~5-10 seconds
+     * 2. Related Endpoint objects are created. Each time we get an update, wait 10 seconds
      *    for any stragglers.
      * 3. The endpoints objects target some number of living objects (unless the Service is
      *    an "empty headless" Service [1] or a Service with '.spec.type: ExternalName').
@@ -27,6 +27,8 @@ import { getVersion } from "../../version";
      * If the Service has not reached a Ready state after 10 minutes, it will
      * time out and mark the resource update as Failed. You can override the default timeout value
      * by setting 'pulumi.com/timeoutSeconds' as a '.metadata.annotation' on the resource.
+     * This approach will be deprecated in favor of customTimeouts. See
+     * https://github.com/pulumi/pulumi-kubernetes/issues/672 for details.
      */
     export class Service extends pulumi.CustomResource {
       /**

diff --git a/sdk/nodejs/extensions/v1beta1/Deployment.ts b/sdk/nodejs/extensions/v1beta1/Deployment.ts
@@ -31,6 +31,8 @@ import { getVersion } from "../../version";
      * If the Deployment has not reached a Ready state after 5 minutes, it will
      * time out and mark the resource update as Failed. You can override the default timeout value
      * by setting 'pulumi.com/timeoutSeconds' as a '.metadata.annotation' on the resource.
+     * This approach will be deprecated in favor of customTimeouts. See
+     * https://github.com/pulumi/pulumi-kubernetes/issues/672 for details.
      */
     export class Deployment extends pulumi.CustomResource {
       /**

diff --git a/sdk/nodejs/extensions/v1beta1/Ingress.ts b/sdk/nodejs/extensions/v1beta1/Ingress.ts
@@ -25,6 +25,8 @@ import { getVersion } from "../../version";
      * If the Ingress has not reached a Ready state after 10 minutes, it will
      * time out and mark the resource update as Failed. You can override the default timeout value
      * by setting 'pulumi.com/timeoutSeconds' as a '.metadata.annotation' on the resource.
+     * This approach will be deprecated in favor of customTimeouts. See
+     * https://github.com/pulumi/pulumi-kubernetes/issues/672 for details.
      */
     export class Ingress extends pulumi.CustomResource {
       /**

diff --git a/sdk/nodejs/networking/v1beta1/Ingress.ts b/sdk/nodejs/networking/v1beta1/Ingress.ts
@@ -23,6 +23,8 @@ import { getVersion } from "../../version";
      * If the Ingress has not reached a Ready state after 10 minutes, it will
      * time out and mark the resource update as Failed. You can override the default timeout value
      * by setting 'pulumi.com/timeoutSeconds' as a '.metadata.annotation' on the resource.
+     * This approach will be deprecated in favor of customTimeouts. See
+     * https://github.com/pulumi/pulumi-kubernetes/issues/672 for details.
      */
     export class Ingress extends pulumi.CustomResource {
       /**

diff --git a/sdk/python/pulumi_kubernetes/apps/v1/Deployment.py b/sdk/python/pulumi_kubernetes/apps/v1/Deployment.py
@@ -35,6 +35,8 @@ class Deployment(pulumi.CustomResource):
     If the Deployment has not reached a Ready state after 5 minutes, it will
     time out and mark the resource update as Failed. You can override the default timeout value
     by setting 'pulumi.com/timeoutSeconds' as a '.metadata.annotation' on the resource.
+    This approach will be deprecated in favor of customTimeouts. See
+    https://github.com/pulumi/pulumi-kubernetes/issues/672 for details.
     """
 
     def __init__(self, resource_name, opts=None, metadata=None, spec=None, status=None, __name__=None, __opts__=None):

diff --git a/sdk/python/pulumi_kubernetes/apps/v1/StatefulSet.py b/sdk/python/pulumi_kubernetes/apps/v1/StatefulSet.py
@@ -30,6 +30,8 @@ class StatefulSet(pulumi.CustomResource):
     If the StatefulSet has not reached a Ready state after 5 minutes, it will
     time out and mark the resource update as Failed. You can override the default timeout value
     by setting 'pulumi.com/timeoutSeconds' as a '.metadata.annotation' on the resource.
+    This approach will be deprecated in favor of customTimeouts. See
+    https://github.com/pulumi/pulumi-kubernetes/issues/672 for details.
     """
 
     def __init__(self, resource_name, opts=None, metadata=None, spec=None, status=None, __name__=None, __opts__=None):

diff --git a/sdk/python/pulumi_kubernetes/apps/v1beta1/Deployment.py b/sdk/python/pulumi_kubernetes/apps/v1beta1/Deployment.py
@@ -37,6 +37,8 @@ class Deployment(pulumi.CustomResource):
     If the Deployment has not reached a Ready state after 5 minutes, it will
     time out and mark the resource update as Failed. You can override the default timeout value
     by setting 'pulumi.com/timeoutSeconds' as a '.metadata.annotation' on the resource.
+    This approach will be deprecated in favor of customTimeouts. See
+    https://github.com/pulumi/pulumi-kubernetes/issues/672 for details.
     """
 
     def __init__(self, resource_name, opts=None, metadata=None, spec=None, status=None, __name__=None, __opts__=None):

diff --git a/sdk/python/pulumi_kubernetes/apps/v1beta1/StatefulSet.py b/sdk/python/pulumi_kubernetes/apps/v1beta1/StatefulSet.py
@@ -32,6 +32,8 @@ class StatefulSet(pulumi.CustomResource):
     If the StatefulSet has not reached a Ready state after 5 minutes, it will
     time out and mark the resource update as Failed. You can override the default timeout value
     by setting 'pulumi.com/timeoutSeconds' as a '.metadata.annotation' on the resource.
+    This approach will be deprecated in favor of customTimeouts. See
+    https://github.com/pulumi/pulumi-kubernetes/issues/672 for details.
     """
 
     def __init__(self, resource_name, opts=None, metadata=None, spec=None, status=None, __name__=None, __opts__=None):

diff --git a/sdk/python/pulumi_kubernetes/apps/v1beta2/Deployment.py b/sdk/python/pulumi_kubernetes/apps/v1beta2/Deployment.py
@@ -37,6 +37,8 @@ class Deployment(pulumi.CustomResource):
     If the Deployment has not reached a Ready state after 5 minutes, it will
     time out and mark the resource update as Failed. You can override the default timeout value
     by setting 'pulumi.com/timeoutSeconds' as a '.metadata.annotation' on the resource.
+    This approach will be deprecated in favor of customTimeouts. See
+    https://github.com/pulumi/pulumi-kubernetes/issues/672 for details.
     """
 
     def __init__(self, resource_name, opts=None, metadata=None, spec=None, status=None, __name__=None, __opts__=None):

diff --git a/sdk/python/pulumi_kubernetes/apps/v1beta2/StatefulSet.py b/sdk/python/pulumi_kubernetes/apps/v1beta2/StatefulSet.py
@@ -32,6 +32,8 @@ class StatefulSet(pulumi.CustomResource):
     If the StatefulSet has not reached a Ready state after 5 minutes, it will
     time out and mark the resource update as Failed. You can override the default timeout value
     by setting 'pulumi.com/timeoutSeconds' as a '.metadata.annotation' on the resource.
+    This approach will be deprecated in favor of customTimeouts. See
+    https://github.com/pulumi/pulumi-kubernetes/issues/672 for details.
     """
 
     def __init__(self, resource_name, opts=None, metadata=None, spec=None, status=None, __name__=None, __opts__=None):

diff --git a/sdk/python/pulumi_kubernetes/core/v1/Pod.py b/sdk/python/pulumi_kubernetes/core/v1/Pod.py
@@ -29,6 +29,8 @@ class Pod(pulumi.CustomResource):
     If the Pod has not reached a Ready state after 5 minutes, it will
     time out and mark the resource update as Failed. You can override the default timeout value
     by setting 'pulumi.com/timeoutSeconds' as a '.metadata.annotation' on the resource.
+    This approach will be deprecated in favor of customTimeouts. See
+    https://github.com/pulumi/pulumi-kubernetes/issues/672 for details.
     """
 
     def __init__(self, resource_name, opts=None, metadata=None, spec=None, status=None, __name__=None, __opts__=None):

diff --git a/sdk/python/pulumi_kubernetes/core/v1/Service.py b/sdk/python/pulumi_kubernetes/core/v1/Service.py
@@ -22,7 +22,7 @@ class Service(pulumi.CustomResource):
     The following conditions are used to determine whether the resource creation has
     succeeded or failed:
     1. Service object exists.
-    2. Related Endpoint objects are created. Each time we get an update, wait ~5-10 seconds
+    2. Related Endpoint objects are created. Each time we get an update, wait 10 seconds
        for any stragglers.
     3. The endpoints objects target some number of living objects (unless the Service is
        an "empty headless" Service [1] or a Service with '.spec.type: ExternalName').
@@ -33,6 +33,8 @@ class Service(pulumi.CustomResource):
     If the Service has not reached a Ready state after 10 minutes, it will
     time out and mark the resource update as Failed. You can override the default timeout value
     by setting 'pulumi.com/timeoutSeconds' as a '.metadata.annotation' on the resource.
+    This approach will be deprecated in favor of customTimeouts. See
+    https://github.com/pulumi/pulumi-kubernetes/issues/672 for details.
     """
 
     def __init__(self, resource_name, opts=None, metadata=None, spec=None, status=None, __name__=None, __opts__=None):

diff --git a/sdk/python/pulumi_kubernetes/extensions/v1beta1/Deployment.py b/sdk/python/pulumi_kubernetes/extensions/v1beta1/Deployment.py
@@ -37,6 +37,8 @@ class Deployment(pulumi.CustomResource):
     If the Deployment has not reached a Ready state after 5 minutes, it will
     time out and mark the resource update as Failed. You can override the default timeout value
     by setting 'pulumi.com/timeoutSeconds' as a '.metadata.annotation' on the resource.
+    This approach will be deprecated in favor of customTimeouts. See
+    https://github.com/pulumi/pulumi-kubernetes/issues/672 for details.
     """
 
     def __init__(self, resource_name, opts=None, metadata=None, spec=None, status=None, __name__=None, __opts__=None):

diff --git a/sdk/python/pulumi_kubernetes/extensions/v1beta1/Ingress.py b/sdk/python/pulumi_kubernetes/extensions/v1beta1/Ingress.py
@@ -31,6 +31,8 @@ class Ingress(pulumi.CustomResource):
     If the Ingress has not reached a Ready state after 10 minutes, it will
     time out and mark the resource update as Failed. You can override the default timeout value
     by setting 'pulumi.com/timeoutSeconds' as a '.metadata.annotation' on the resource.
+    This approach will be deprecated in favor of customTimeouts. See
+    https://github.com/pulumi/pulumi-kubernetes/issues/672 for details.
     """
 
     def __init__(self, resource_name, opts=None, metadata=None, spec=None, status=None, __name__=None, __opts__=None):

diff --git a/sdk/python/pulumi_kubernetes/networking/v1beta1/Ingress.py b/sdk/python/pulumi_kubernetes/networking/v1beta1/Ingress.py
@@ -29,6 +29,8 @@ class Ingress(pulumi.CustomResource):
     If the Ingress has not reached a Ready state after 10 minutes, it will
     time out and mark the resource update as Failed. You can override the default timeout value
     by setting 'pulumi.com/timeoutSeconds' as a '.metadata.annotation' on the resource.
+    This approach will be deprecated in favor of customTimeouts. See
+    https://github.com/pulumi/pulumi-kubernetes/issues/672 for details.
     """
 
     def __init__(self, resource_name, opts=None, metadata=None, spec=None, status=None, __name__=None, __opts__=None):