Update NodeJS Helm v3 to use native client

pulumi · Aug 28, 2020 · b5b07af · b5b07af
1 parent 1c8399c
commit b5b07af
Show file tree

Hide file tree

Showing 47 changed files with 613 additions and 199 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 -   Upgrade to Pulumi v2.9.0, which adds type annotations and input/output classes to Python (https://github.com/pulumi/pulumi-kubernetes/pull/1276)
 -   Switch Helm v3 logic to use native library. (https://github.com/pulumi/pulumi-kubernetes/pull/1263)
 -   Bump python requests version dependency. (https://github.com/pulumi/pulumi-kubernetes/pull/1274)
+-   Update NodeJS Helm v3 to use native client. (https://github.com/pulumi/pulumi-kubernetes/pull/1279)
 
 ## 2.5.0 (August 26, 2020)
 

diff --git a/provider/cmd/pulumi-gen-kubernetes/main.go b/provider/cmd/pulumi-gen-kubernetes/main.go
@@ -194,7 +194,7 @@ func writeNodeJSClient(pkg *schema.Package, outdir, templateDir string) {
 	overlays := map[string][]byte{
 		"apiextensions/customResource.ts": mustLoadFile(filepath.Join(templateDir, "apiextensions", "customResource.ts")),
 		"helm/v2/helm.ts":                 mustLoadFile(filepath.Join(templateDir, "helm", "v2", "helm.ts")),
-		"helm/v3/helm.ts":                 mustLoadFile(filepath.Join(templateDir, "helm", "v2", "helm.ts")), // v3 support is currently identical to v2
+		"helm/v3/helm.ts":                 mustLoadFile(filepath.Join(templateDir, "helm", "v3", "helm.ts")),
 		"kustomize/kustomize.ts":          mustLoadFile(filepath.Join(templateDir, "kustomize", "kustomize.ts")),
 		"yaml/yaml.ts":                    mustRenderTemplate(filepath.Join(templateDir, "yaml", "yaml.tmpl"), templateResources),
 	}

diff --git a/provider/pkg/gen/nodejs-templates/helm/v2/helm.ts b/provider/pkg/gen/nodejs-templates/helm/v2/helm.ts
@@ -43,7 +43,7 @@ import * as yaml from "../../yaml/index";
  * ```typescript
  * import * as k8s from "@pulumi/kubernetes";
  *
- * const nginxIngress = new k8s.helm.v3.Chart("nginx-ingress", {
+ * const nginxIngress = new k8s.helm.v2.Chart("nginx-ingress", {
  *   path: "./nginx-ingress",
  * });
  * ```
@@ -52,7 +52,7 @@ import * as yaml from "../../yaml/index";
  * ```typescript
  * import * as k8s from "@pulumi/kubernetes";
  *
- * const nginxIngress = new k8s.helm.v3.Chart("nginx-ingress", {
+ * const nginxIngress = new k8s.helm.v2.Chart("nginx-ingress", {
  *   chart: "nginx-ingress",
  *   version: "1.24.4",
  *   fetchOpts:{
@@ -65,7 +65,7 @@ import * as yaml from "../../yaml/index";
  * ```typescript
  * import * as k8s from "@pulumi/kubernetes";
  *
- * const nginxIngress = new k8s.helm.v3.Chart("nginx-ingress", {
+ * const nginxIngress = new k8s.helm.v2.Chart("nginx-ingress", {
  *   chart: "nginx-ingress",
  *   version: "1.24.4",
  *   fetchOpts:{
@@ -85,7 +85,7 @@ import * as yaml from "../../yaml/index";
  * ```typescript
  * import * as k8s from "@pulumi/kubernetes";
  *
- * const nginxIngress = new k8s.helm.v3.Chart("nginx-ingress", {
+ * const nginxIngress = new k8s.helm.v2.Chart("nginx-ingress", {
  *   chart: "nginx-ingress",
  *   version: "1.24.4",
  *   namespace: "test-namespace",
@@ -99,7 +99,7 @@ import * as yaml from "../../yaml/index";
  * ```typescript
  * import * as k8s from "@pulumi/kubernetes";
  *
- * const nginxIngress = new k8s.helm.v3.Chart("nginx-ingress", {
+ * const nginxIngress = new k8s.helm.v2.Chart("nginx-ingress", {
  *   chart: "nginx-ingress",
  *   version: "1.24.4",
  *   fetchOpts:{