Skip to content

Commit

Permalink
Update comment
Browse files Browse the repository at this point in the history
  • Loading branch information
lblackstone committed Aug 2, 2019
1 parent 9c0b6a9 commit c13ebbb
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
6 changes: 4 additions & 2 deletions pkg/gen/python-templates/helm/v2/helm.py
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,10 @@ def _parse_chart(all_config: Tuple[str, Union[ChartOpts, LocalChartOpts], pulumi
release_name, config, opts = all_config

# Create temporary directory and file to hold chart data and override values.
# Note: Using context managers for this was not playing nicely with the async Outputs, so we're using
# the lower-level APIs and manually cleaning up once we're done.
# Note: We're intentionally using the lower-level APIs here because the async Outputs are being handled in
# a different scope, which was causing the temporary files/directory to be deleted before they were referenced
# in the Output handlers. We manually clean these up once we're done with another async handler that depends
# on the result of the operations.
overrides, overrides_filename = mkstemp()
chart_dir = mkdtemp()

Expand Down
6 changes: 4 additions & 2 deletions sdk/python/pulumi_kubernetes/helm/v2/helm.py
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,10 @@ def _parse_chart(all_config: Tuple[str, Union[ChartOpts, LocalChartOpts], pulumi
release_name, config, opts = all_config

# Create temporary directory and file to hold chart data and override values.
# Note: Using context managers for this was not playing nicely with the async Outputs, so we're using
# the lower-level APIs and manually cleaning up once we're done.
# Note: We're intentionally using the lower-level APIs here because the async Outputs are being handled in
# a different scope, which was causing the temporary files/directory to be deleted before they were referenced
# in the Output handlers. We manually clean these up once we're done with another async handler that depends
# on the result of the operations.
overrides, overrides_filename = mkstemp()
chart_dir = mkdtemp()

Expand Down

0 comments on commit c13ebbb

Please sign in to comment.