Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart version should be optional #255

Closed
lukehoban opened this issue Oct 31, 2018 · 0 comments · Fixed by #284
Closed

Chart version should be optional #255

lukehoban opened this issue Oct 31, 2018 · 0 comments · Fixed by #284
Assignees
@lukehoban
Labels
area/helm customer/feedback Feedback from customers
Milestone
0.19

Comments

@lukehoban
Copy link
Contributor

Helm does not require a version to be specified when installing a chart. helm.v2.Chart should mark version as optional.

Note that this can be worked around by passing version: <any>undefined, since it is just an issue in the TypeScript typing not the JavaScript implementation.
@lukehoban lukehoban added this to the 0.19 milestone Oct 31, 2018
@lukehoban lukehoban added the customer/feedback Feedback from customers label Oct 31, 2018
lukehoban pushed a commit that referenced this issue Nov 18, 2018
Make version optional on helm.ChartOpts
0a9bf36 
Fixes #255.
@lukehoban lukehoban mentioned this issue Nov 18, 2018
Merged
@lukehoban lukehoban assigned lukehoban and unassigned hausdorff Nov 18, 2018
lukehoban added a commit that referenced this issue Nov 21, 2018
@lukehoban
Allow more flexible chart options (#284)
2330f0b 
Fixes #255.
Fixes #229.
Fixes #257.

Align more closely with `helm` options for chart references to support all scenarios supported by Helm including (a) getting latest by passing no version (b) using explicitly repo URLs (c) providing fully qualified URLs to charts. 

All of the following now work:

```javascript
// 1. Explicit repo/chart/version - not technically part of `helm` format but needed for back compat
repo: "stable",
chart: "nginx-lego",
version: "0.3.1",

// 2. Reference to "latest"
repo: "stable",
chart: "nginx-lego",

// 3. Helm "chart reference"
chart: "stable/nginx-lego",

// 4. Helm "chart reference" with explicit version
chart: "stable/nginx-lego",
version: "0.3.1"

// 5. Helm "chart reference and repo url" with explicit version
chart: "nginx-lego",
version: "0.3.1",
fetchOpts: {
  repo: "https://kubernetes-charts.storage.googleapis.com"
},

// 6. Helm "chart reference and repo url" 
chart: "nginx-lego",
fetchOpts: {
  repo: "https://kubernetes-charts.storage.googleapis.com"
},

// 7. Helm "absolute URL" 
chart: "https://kubernetes-charts.storage.googleapis.com/nginx-lego-0.3.1.tgz",
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukehoban lukehoban

Labels
area/helm customer/feedback Feedback from customers
Projects
None yet
Milestone
0.19
Development

Successfully merging a pull request may close this issue.

Allow more flexible chart options pulumi/pulumi-kubernetes
2 participants
@lukehoban @hausdorff