User agent header not correct

[ringods]

What happened?

A customer reports that the HTTP header used for the user agent is not sent correctly. See the example below.

• the header name should not be userAgent but User-Agent
• the actual provider binary version is missing. It reports v0.0.0
• there is a possible interpolation not working correctly, leading to an explicit $Format string being rendered

Example

Taken from the Kubernetes audit logs:

"userAgent": "pulumi-resource-kubernetes/v0.0.0 (darwin/arm64) kubernetes/$Format",

Output of pulumi about

CLI
Version      3.134.1
Go Version   go1.23.1
Go Compiler  gc

Plugins
KIND      NAME        VERSION
resource  aws         6.53.0
resource  cloudinit   1.4.7
resource  kubernetes  4.18.1
language  python      unknown
resource  random      4.16.5

Host
OS       darwin
Version  14.5
Arch     arm64

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

[blampe]

@ringods can you share how the user is setting this header? Is this part of an Automation API program?

[rquitales]

The user-agent is likely coming from client-go's default:
https://github.com/kubernetes/client-go/blob/23900f492969db045e8a36396852381fd189569b/rest/config.go#L495-L508

Without digging too deep, the fix for this probably requires us to accurately set the user-agent here:

pulumi-kubernetes/provider/pkg/provider/provider.go

Lines 828 to 859 in 605307c

	var config *rest.Config
	if !k.clusterUnreachable {
	contract.Assertf(kubeconfig != nil, "expected kubeconfig to be initialized")
	var err error
	config, err = kubeconfig.ClientConfig()
	if err != nil {
	k.clusterUnreachable = true
	k.clusterUnreachableReason = fmt.Sprintf("unable to load Kubernetes client configuration from kubeconfig file. Make sure you have: \n\n"+
	" \t • set up the provider as per https://www.pulumi.com/registry/packages/kubernetes/installation-configuration/ \n\n %v", err)
	config = nil
	} else {
	if kubeClientSettings.Burst != nil {
	config.Burst = *kubeClientSettings.Burst
	helmSettings.BurstLimit = *kubeClientSettings.Burst
	logger.V(9).Infof("kube client burst set to %v", config.Burst)
	}
	if kubeClientSettings.QPS != nil {
	config.QPS = float32(*kubeClientSettings.QPS)
	helmSettings.QPS = float32(*kubeClientSettings.QPS)
	logger.V(9).Infof("kube client QPS set to %v", config.QPS)
	}
	if kubeClientSettings.Timeout != nil {
	config.Timeout = time.Duration(*kubeClientSettings.Timeout) * time.Second
	helmFlags.Timeout = ptr.To(strconv.Itoa(*kubeClientSettings.Timeout))
	logger.V(9).Infof("kube client timeout set to %v", config.Timeout)
	}
	config.WarningHandler = rest.NoWarnings{}
	}
	}
	var err error
	k.clientSet, k.logClient, err = k.makeClient(k.canceler.context, config)